Diagram/create diagram service #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm this doesn't seem to have worked as intended (diff is still huge), let me troubleshoot - I think I might need to do an extra step to merge in dev. |
Signed-off-by: Jay Clark <[email protected]>
Signed-off-by: Jay Clark <[email protected]>
jayeclark
force-pushed
the
diagram/create-diagram-service
branch
from
0a71fd5 to
9f43827
Compare
|
Fixed! |
Signed-off-by: Jay Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the second PR (it depends on #17 - once 17 is merged into dev, the diff will be much much smaller, as this branch is based off of that one.) It just creates a Diagram.js file and copies relevant functions over into it.
This is another copy-paste just to keep track of where the old code is moving. The PR I have lined up after this one (branch
diagram/refactor-to-classactually starts updating/fixing the code in Diagram (but, this way instead of thousands of lines of code changing when I make my first 'real' changes, only a few dozen will be.)