-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python-constraint to avoid conda-forge dependencies. #61
Conversation
Signed-off-by: Dusty DeWeese <[email protected]>
Ha, we just discussed adding this, like minutes ago. LGTM for me, but I'll ask @ajelinski to take a look as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
os: linux | ||
dist: xenial | ||
env: | ||
- PACKAGE=misc/python-constraint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should, probably, go to litex-conda-misc, but since it's a direct dependency of vtr-optimized, I don't think it's a big problem to have it here
@@ -0,0 +1,51 @@ | |||
{% set name = "python-constraint" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file autogenerated with something like conda skeleton pypi {packagename}
? I actually never used it before, but if this is the result, then it's pretty good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but I had to edit a bit, and change from .gz to .bz2.
There should be another way to fix the python-constraint problem. Basically the condarc file in All the dependencies for vtr-optimized will be taken from So basically the condarc file would look like the following:
in the current implementation of the vtr-optimized package, all the various dependencies are taken from conda-forge, hence the conflicts |
@acomodi I tried this, based on this tip, except reversed to avoid conda-forge, but unfortunately, it didn't work. There were still dependencies from conda-forge in |
@ajelinski Any comments? |
Are you sure you tried with channels in this exact order? The order matters and in the link provided I've tested how the recipe is rendered after adding the
This is because conda-build gets all packages it needs from
because conda-build will use all packages it can from the Those requirements can be satisfied without |
Btw. |
I have added a branch with the aforementioned The package built in that CI can be installed with:
|
@ajelinski Thanks. I'll try your package and close this if it works, unless there is still value in it. |
@ajelinski It seems to work, so made a PR with your branch: #62 |
Superseded by #62 |
Any packages with a
condarc
specifying outside channels will require those channels to be available to install them.Depending in conda-forge is undesirable because it can conflict with many of the default packages.
pip
cannot be used directly in a conda recipe, so PyPI packages must be converted to Conda packages.This has caused problems with
vtr-optimized
(PR), which this PR aims to resolve, but there are other packages usingcondarc
as well.