-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update environment.yml to use vtr-optimized (vtr compiled with PGO) #1892
Conversation
42c906f
to
0604ba0
Compare
@mithro Could you help me figure out why Conda fails? |
My theory is that the condarc file in the package causes this, because
|
I think I know what's happening. Some dependencies are coming from |
0604ba0
to
daf3471
Compare
The fact that there are some conda-forge dependencies is a hint that there is something wrong with the vtr-optmized package. Looking at the package description in litex-hub-conda, I see that there is a condarc file which should be deleted from there: https://github.com/litex-hub/litex-conda-eda/blob/master/pnr/vtr-optimized/condarc. The problem is that conda-forge generates this kinds of issues and leads to instability, and we should not use it at all.
|
Unfortunately, there is no other good way to get |
I have created a package for |
daf3471
to
6998673
Compare
Signed-off-by: Dusty DeWeese <[email protected]> Co-authored-by: Alessandro Comodi <[email protected]>
6998673
to
3900002
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge if green
I'm not seeing an improvement in overall runtime. This is likely because most of the time is spent during the lookahead computation. @HackerFoo have you explored/tested PGO improvements on the lookahead computation stuff? |
I have not. It might be worth trying a separate PGO build optimized for lookup computation, but it's probably not worth the ~10% performance gain, and I suspect that lookup is mostly memory bound, so it will probably have less effect. I think the most effective way to improve lookup time is by balancing the parallel workload better, and shortening the tail. |
No description provided.