-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplify deployment with nginx #36
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexander Onnikov <[email protected]>
@aonnikov you beat me to it, most of the fixes you just pushed I have laying unpushed on my machine 😅 |
Fair enough, added you as a co-author (know, it is dirty but better than nothing). Much appreciate your contribution! |
Signed-off-by: veryCrunchy <[email protected]>
Network isn't needed as only the nginx port is exposed
@aonnikov there are a lot of duplicate env variables set in the compose.yml, |
Yeah, all of them are used, but some of them are not mandatory and can be omitted. |
Yes, I am self hosting using the main branch and instructions from here: https://github.com/hcengineering/huly-selfhost. |
@Sharlyll This PR is meant to fix all the issues with the main branch. Please try the nginx branch on git clone -b nginx https://github.com/veryCrunchy/huly-selfhost.git |
Hi Thanks in advance |
@Sharlyll follow these steps: https://github.com/veryCrunchy/huly-selfhost/tree/nginx |
I still the same issue with account service not available. My configuration:
|
Thanks for your response.
Huly should be up |
I tested this out on my ubuntu instance and it works. I had to stop my nginx service on the server and leave the work to the docker nginx container. |
What does this Is it referring to the port that most people would pick 443 or is it referring to where the "front" container is attached to, 8087 in the standard Huly setup? |
443 would be for https, so if you have ssl certs, you could use this. The port you should use is most likely port 80, but you could use port 8080 or 80xx (some other number) if you want to use http://localhost:8080 or http://localhost:80xx (e.g. 8085). If you don't have any other web apps running, port 80 is best as you don't have to specify 80 in the url as it is the default. |
As a new user trying to get this thing up and running on a private server for my small company, this confuses me. Is the self hosted solution viable or not ? Is it only for local use ? I find it very weird that this repo is the self hosted solution, but then you say the goal is not for users to put new instances out there on the internet. |
This pr makes the self hosted solution more viable. Whilst this repo prior to the pr gives the necessary resources for a technical user to be able to self host. |
Wanted to say thanks to @veryCrunchy. I am up and running now and look forward to this being merged in as the basis going forward. I look forward to helping, as I'm able to, this project moving forward. |
@shanzez do you run it on 80/443 port? I would be happy to merge this, because this PR solves most of the problems self-hosters usually ask, but the last time I tried to set it up locally, it did not work on custom port. |
A custom port definitely works. |
@aonnikov could you try this? (on linux for now, I believe mac still doesn't work) |
Would a cli solution with Deno be accepted? |
For now this pr can be merged. |
Howdy @aonnikov, we use:
and we redirect port 80 to 443. |
I am running this on a Mac Studio M1, btw. Working great. |
btw, in order to use the version 333 instead of 295, I did have to add some DB_URL's in. Some places I replaced MONGO_URL with it, and in one place I had both MONGO_URL and DB_URL. In the compose template file. I am now updated to 337 locally. |
@shanzez thanks |
Yep will try later.
Yeah, why not. The only thing, is that we are thinking about separating "official" and community-driven examples to give you guys more freedom with regards to what tools to use 😄 At this point not sure if it should be just a folder within the same repo, or separate repository. Any thoughts on this? |
This PR fixes:
Resolves #2
Resolves #3
Resolves #6
Resolves #11
Resolves #15
Resolves #21
Resolves #27
Note
love with livekit will be implemented in a separate pr after this one has been merged