Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #87

Conversation

kalashnikovisme
Copy link

@kalashnikovisme kalashnikovisme commented Oct 26, 2024

  • Removed $ from commands, cuz it interferes in copying these commands.
  • Added & to docker compose up command

Signed-off-by: Pavel Kalashnikov <[email protected]>
Signed-off-by: Pavel Kalashnikov <[email protected]>
$ sudo systemctl restart nginx
$ sudo docker compose up
sudo systemctl restart nginx
sudo docker compose up &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the & supposed to do here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update your comment to an & instead of $

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the comment of the PR.

@veryCrunchy
Copy link
Contributor

Instead of using &, we should use the Docker Compose provided -d flag to run the services in the background. This change is already included in my open PR (#36).

To avoid potential merge conflicts, it might be best to close this PR, as my changes will be merged soon.

@kalashnikovisme
Copy link
Author

@veryCrunchy got it! Thank you!

@kalashnikovisme kalashnikovisme deleted the kalashnikovisme-patch-1 branch November 22, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants