Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate menhir parser and elaborator tests #1220

Open
wants to merge 246 commits into
base: dev
Choose a base branch
from
Open

Integrate menhir parser and elaborator tests #1220

wants to merge 246 commits into from

Conversation

7h3kk1d
Copy link
Contributor

@7h3kk1d 7h3kk1d commented Feb 25, 2024

No description provided.

green726 and others added 17 commits July 27, 2023 09:56
@green726
Initial project organization & setup
1b4a6a4
@green726
preliminary & minimal implementation of the lexer
d6a6e95
@green726
got initial version of parser to work - also added testing code
88f5cc7
@green726
drastically expanded parser, lexer, ast (reworked pats vs exps, added…
5cfd56a 
… more binops, etc)
@green726
added cases & rules
4659076
@green726
Expanded the patterns and changed rules/cases
a3c77ed
@green726
Added arrow types & expanded test
7759144
@green726
formatting
a01b07c
@green726
Merge branch 'dev' into menhir_parser
556e8b4
@green726
started working on the menhir ast -> DHExp translation - got the simp…
c32dfb2 
…le forms done
@green726
Merge branch 'dev' into menhir_parser
bfe2db1
@green726
finished up preliminary translation
9080650
@green726
Added in the cast syntax to the menhir parser; still need to test
af03c40
@7h3kk1d
Merge remote-tracking branch 'origin/dev' into menhir_parser
8aff486
@7h3kk1d
Reformat
951d4a2
@7h3kk1d
Integrate menhir tests with the haz3ltests
97c5187
@7h3kk1d
Try failing test
3bc4227
@cyrus-
Copy link
Member

cyrus- commented Feb 27, 2024

@green726 are you taking a look at this PR or what is the plan? @7h3kk1d

@7h3kk1d
Copy link
Contributor Author

7h3kk1d commented Feb 27, 2024

@green726 are you taking a look at this PR or what is the plan? @7h3kk1d

This was still in dev from my perspective but @green726 is going to take over it from now and let me know if they need assistance.

@cyrus- cyrus- added needs-polish for PRs that are substantially complete but need final polish needs-merge for PRs that need a merge from dev labels Mar 1, 2024
@cyrus- cyrus- changed the base branch from menhir_parser to dev March 1, 2024 05:23
@cyrus- cyrus- mentioned this pull request Mar 1, 2024
Closed
@cyrus- cyrus- removed the needs-merge for PRs that need a merge from dev label Mar 14, 2024
@7h3kk1d
Copy link
Contributor Author

7h3kk1d commented Dec 20, 2024

@green726 I made a bunch more fixes in the parser, conversion, and tests. There's still come cleanup I need to do before we merge but let me know what else you want to look at before I give it to Cyrus for review.

7h3kk1d
7h3kk1d commented Dec 20, 2024
View reviewed changes
src/haz3lmenhir/AST.re Outdated Show resolved Hide resolved
7h3kk1d added 26 commits December 20, 2024 16:04
@7h3kk1d
Cleaning up tests
44caaa0
@7h3kk1d
More test cleanup
57de33c
@7h3kk1d
More cleanup
a7c80e9
@7h3kk1d
Address todos in Conversion
57b0a1d
@7h3kk1d
Rename binop
ebe9380
@7h3kk1d
Adjust comment
dd4dffa
@7h3kk1d
Remove todo
db04947
@7h3kk1d
Simplify qualified imports
5cdb818
@7h3kk1d
Refactor gen_exp_sized to use let* for improved readability and struc…
d220808 
…ture
@7h3kk1d
Finish converting gen_exp to let notation
423d874
@7h3kk1d
Refmt
8deebf7
@7h3kk1d
Refactor gen_typ_sized to use let notation
ccda1d2
@7h3kk1d
Refactor sumtype to use let notation
109f130
@7h3kk1d
Refactor gen_pat_sized to use let notation
64d1a04
@7h3kk1d
Remove unused gen_exp and gen_typ definitions
ea51395
@7h3kk1d
Rename arb_str to arb_alpha_str
98e7730
@7h3kk1d
Inlining cleanup
ce23f3f
@7h3kk1d
Refactor to gen_literal_string
acc2fca
@7h3kk1d
More let notation
926ab68
@7h3kk1d
Add annotation
7472c64
@7h3kk1d
Cleanup
24ebb17
@7h3kk1d
Turn arb_constructor_ident into gen_constructor_ident
6618e86
@7h3kk1d
Rename generators
35ddd72
@7h3kk1d
Add detailed documentation for generator functions in AST
9620c17
@7h3kk1d
Remove TODO comment regarding builtins in the parser
ae1ae3d
@7h3kk1d
Remove invalid deferral test
ce578a3
@7h3kk1d 7h3kk1d marked this pull request as ready for review December 22, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@green726 green726 green726 left review comments

@cyrus- cyrus- Awaiting requested review from cyrus-

Requested changes must be addressed to merge this pull request.

Assignees

@green726 green726

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@7h3kk1d @cyrus- @green726