Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menhir parser #1071

Closed
wants to merge 13 commits into from
Closed

Menhir parser #1071

wants to merge 13 commits into from

Conversation

green726
Copy link
Member

@green726 green726 commented Aug 4, 2023

No description provided.

@green726 green726 added the in-development for PRs that remain in development label Aug 4, 2023
@green726 green726 self-assigned this Aug 4, 2023
@green726 green726 marked this pull request as draft August 4, 2023 20:04
@cyrus-
Copy link
Member

cyrus- commented Nov 11, 2023

@green726 I'm looking at upping our testing game and would like to be able to write tests in concrete syntax. We can run strings through tylr to get a UExp, but there is no equivalent for internal expressions. How do you feel about finishing up this PR to provide a parser for DHExp terms?

@green726
Copy link
Member Author

green726 commented Nov 11, 2023

@green726 I'm looking at upping our testing game and would like to be able to write tests in concrete syntax. We can run strings through tylr to get a UExp, but there is no equivalent for internal expressions. How do you feel about finishing up this PR to provide a parser for DHExp terms?

@cyrus- Sure! IIRC, the menhir parser was pretty much fully written and I just needed to translate the AST output by Menhir into the DHExp/DHPat terms. However, I may not be able to get much work done on this in the next few weeks; I have a paper due back with revisions to a journal in <2 weeks (solo project I submitted to Journal of Computer Languages), and I still have a lot of writing left to do. Once I get that paper in though, I should hopefully be able to finish this pretty quickly. Maybe we could do a zoom or I could hop on to office hours at some point to discuss this more?

@cyrus-
Copy link
Member

cyrus- commented Nov 12, 2023

@green726 okay sounds good. (let me know if you want any feedback on your paper!)

@green726
Copy link
Member Author

@green726 okay sounds good. (let me know if you want any feedback on your paper!)

Thank you! I appreciate the offer and will let you know when it's almost done.

@cyrus-
Copy link
Member

cyrus- commented Mar 1, 2024

Closing in favor of #1220 since the merge was already done there.

@cyrus- cyrus- closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-development for PRs that remain in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants