Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors deserializing request bodies #76

Merged
merged 1 commit into from
Nov 8, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions rust-connector-sdk/src/json_rejection.rs
Original file line number Diff line number Diff line change
@@ -1,29 +1,33 @@
//! We want errors returned from failed json extractors to be formatted as json as well.

use axum::extract;
use axum::{http::StatusCode, response::IntoResponse};
use axum::response::IntoResponse;
use ndc_client::models;

pub struct JsonRejection {
error: models::ErrorResponse,
status: StatusCode,
}
pub struct JsonRejection(extract::rejection::JsonRejection);

impl From<extract::rejection::JsonRejection> for JsonRejection {
fn from(rejection: extract::rejection::JsonRejection) -> JsonRejection {
JsonRejection {
error: models::ErrorResponse {
message: "Parse error".to_string(),
details: serde_json::Value::String(rejection.body_text()),
},
status: rejection.status(),
}
JsonRejection(rejection)
}
}

impl IntoResponse for JsonRejection {
fn into_response(self) -> axum::response::Response {
let payload = serde_json::to_value(self.error).unwrap();
(self.status, extract::Json(payload)).into_response()
fn into_response(self: JsonRejection) -> axum::response::Response {
let JsonRejection(rejection) = self;
tracing::error!(
meta.signal_type = "log",
event.domain = "ndc",
event.name = "Unable to deserialize request body",
name = "Unable to deserialize request body",
body = %rejection.body_text(),
error = true,
);
let error = models::ErrorResponse {
message: "Parse error".to_string(),
details: serde_json::Value::String(rejection.body_text()),
};
let payload = serde_json::to_value(error).unwrap();
(rejection.status(), extract::Json(payload)).into_response()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a little bananas to me. Why are we using an extractor in a response?

I realize you didn't write this, but it does not seem correct.

Let's look into this separately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out that this makes sense to an extent, since it appears to be Axum's way to communicate/build up IntoResponse trait implementations from smaller parts: https://docs.rs/axum/0.6.20/axum/response/trait.IntoResponse.html

}
}