Log errors deserializing request bodies #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamirTalwar
approved these changes
Nov 8, 2023
| details: serde_json::Value::String(rejection.body_text()), | ||
| }; | ||
| let payload = serde_json::to_value(error).unwrap(); | ||
| (rejection.status(), extract::Json(payload)).into_response() |
There was a problem hiding this comment.
This seems a little bananas to me. Why are we using an extractor in a response?
I realize you didn't write this, but it does not seem correct.
Let's look into this separately.
There was a problem hiding this comment.
It turns out that this makes sense to an extent, since it appears to be Axum's way to communicate/build up IntoResponse trait implementations from smaller parts: https://docs.rs/axum/0.6.20/axum/response/trait.IntoResponse.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to log when we cannot fundamentally make sense of the requests we receive.