Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependabot and go.mod aws-sdk-go-v2 exclusions #34425

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 15, 2023

Description

aws/aws-sdk-go-v2#2365 introduced a new INI file parser to aws-sdk-go-v2.
We can now remove our dependabot aws-sdk-go-v2 exclusions.
Also removes the go.mod exclusions and updates to the current module versions.

Relations

Relates aws/aws-sdk-go-v2#2365.
Relates aws/aws-sdk-go-v2#2363.
Relates aws/aws-sdk-go-v2#2359.
Relates aws/aws-sdk-go-v2#2349.
Relates #34300.
Relates #34313.
Relates #34327.
Relates aws/aws-sdk-go-v2#2369.
Relates #34429.
Relates hashicorp/aws-sdk-go-base#787.

Output from Acceptance Testing

% go test -v -run=TestSharedConfigFileParsing ./internal/provider    
=== RUN   TestSharedConfigFileParsing
=== RUN   TestSharedConfigFileParsing/leading_whitespace
--- PASS: TestSharedConfigFileParsing (0.13s)
    --- PASS: TestSharedConfigFileParsing/leading_whitespace (0.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/provider	5.739s

DON'T MERGE UNTIL WE HAVE RESOLUTION UPSTREAM

Remove `aws_sdk-go-v2` exclusions.
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code labels Nov 15, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 15, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Nov 15, 2023
@ewbankkit ewbankkit modified the milestone: v5.27.0 Nov 15, 2023
@ewbankkit ewbankkit changed the title Remove dependabot aws-sdk-go-v2 exclusions Remove dependabot and go.mod aws-sdk-go-v2 exclusions Nov 17, 2023
@ewbankkit
Copy link
Contributor Author

Failing unit test is expected -- aws/aws-sdk-go-v2#2369.

@ewbankkit ewbankkit merged commit 8df2bf1 into main Nov 20, 2023
36 of 37 checks passed
@ewbankkit ewbankkit deleted the ewbankkit-patch-1 branch November 20, 2023 13:30
@github-actions github-actions bot added this to the v5.27.0 milestone Nov 20, 2023
Copy link

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. github_actions Pull requests that update Github_actions code prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants