Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove go.mod aws-sdk-go-v2 exclusions #798

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Remove go.mod aws-sdk-go-v2 exclusions #798

merged 2 commits into from
Nov 20, 2023

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Removes the aws-sdk-go-v2 go.mod exclusions added for INI file parsing bugs. aws/aws-sdk-go-v2#2365 and aws/aws-sdk-go-v2#2371 and should have resolved them all.
We need to use aws-sdk-go-v2 module versions released since aws/aws-sdk-go-v2#2364, and the exclusions were preventing this.

Closes #783.
Relates aws/aws-sdk-go-v2#2370.
Relates hashicorp/terraform-provider-aws#34425.

@ewbankkit ewbankkit requested a review from a team as a code owner November 20, 2023 13:04
@ewbankkit ewbankkit added dependencies Pull requests that update a dependency file upstream Depends on the AWS SDK labels Nov 20, 2023
@ewbankkit ewbankkit mentioned this pull request Nov 20, 2023
Merged
jar-b
jar-b approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit a30fc9f into main Nov 20, 2023
12 checks passed
@ewbankkit ewbankkit deleted the td-remove-go.mod-aws-sdk-go-v2-exclusions branch November 20, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file upstream Depends on the AWS SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove go.mod aws-sdk-go-v2 exclusions
2 participants
@ewbankkit @jar-b