Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated releng team from codeowners #326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,3 @@


@hashicorp/consul-ecs

/.github/workflows/* @hashicorp/release-engineering @hashicorp/consul-ecs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team hashicorp/release-engineering is now hashicorp/team-selfmanaged-releng andteam-cloud-releng. We just need to pick if this repo should be managed by cloud or selfmanaged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not sure if consul-ecs is a valid team

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want this file to be:

* @hashicorp/consul-selfmanage-maintainers

# release configuration
/.github/workflows/*            @hashicorp/team-selfmanaged-releng @hashicorp/consul-selfmanage-maintainers

@NiniOak maybe you can make a new PR and we can ask that this one not get merged?

Loading