Remove deprecated releng team from codeowners #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiniOak
reviewed
Nov 18, 2024
| @@ -3,5 +3,3 @@ | |||
|
|
|||
|
|
|||
| @hashicorp/consul-ecs | |||
|
|
|||
| /.github/workflows/* @hashicorp/release-engineering @hashicorp/consul-ecs | |||
There was a problem hiding this comment.
Team hashicorp/release-engineering is now hashicorp/team-selfmanaged-releng andteam-cloud-releng. We just need to pick if this repo should be managed by cloud or selfmanaged
There was a problem hiding this comment.
Also not sure if consul-ecs is a valid team
There was a problem hiding this comment.
I think we want this file to be:
* @hashicorp/consul-selfmanage-maintainers
# release configuration
/.github/workflows/* @hashicorp/team-selfmanaged-releng @hashicorp/consul-selfmanage-maintainers
@NiniOak maybe you can make a new PR and we can ask that this one not get merged?
|
Please close PR, new PR created #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: