Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typography on "Request Review" modal #675

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Improve typography on "Request Review" modal #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 11 additions & 26 deletions web/app/components/document/sidebar.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,32 +736,17 @@
</div>
{{else}}
<ul class="mb-6 space-y-1 text-body-300">
<li class="flex items-center">
<div
class="mr-2.5 inline-flex rounded-full text-color-palette-neutral-400"
>
<FlightIcon @size="16" @name="at-sign" />
</div>
Approvers and people subscribed to “{{@document.product}}” will be
notified.
</li>
<li class="flex items-center">
<div
class="mr-2.5 inline-flex rounded-full text-color-palette-neutral-400"
>
<FlightIcon @size="16" @name="radio" />
</div>
Your document will appear in Hermes and Google Workspace search.
</li>
<li class="flex items-center">
<div
class="mr-2.5 inline-flex rounded-full text-color-palette-neutral-400"
>

<FlightIcon @size="16" @name="globe-private" />
</div>
Published documents cannot be deleted but can be archived.
</li>
{{#each this.requestReviewBulletPoints as |b|}}
<li class="flex gap-2.5">
<FlightIcon
@name={{b.icon}}
class="mt-1 text-color-foreground-disabled"
/>
<span>
{{b.text}}
</span>
</li>
{{/each}}
</ul>

<Hds::Form::Field @layout="vertical" as |F|>
Expand Down
17 changes: 17 additions & 0 deletions web/app/components/document/sidebar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,23 @@ export default class DocumentSidebarComponent extends Component<DocumentSidebarC
};
}

protected get requestReviewBulletPoints() {
return [
{
icon: "at-sign",
text: `Approvers and people subscribed to “${this.args.document.product}” will be notified.`,
},
{
icon: "radio",
text: "Your document will appear in Hermes and Google Workspace search.",
},
{
icon: "globe-private",
text: "Published documents cannot be deleted but can be archived.",
},
];
}

/**
* Whether the share button is in the process of creating a shareable link.
* Used to determine the icon and tooltip text of the share button.
Expand Down
Loading