Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typography on "Request Review" modal #675

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Improve typography on "Request Review" modal #675

merged 1 commit into from
Apr 15, 2024

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Apr 15, 2024 •
edited
Loading

Touch-up to the "Request Review" modal:

  • Improved icon placement when a bullet point spans two lines (i.e., when the product name is long)
  • Simplified template markup

@jeffdaley jeffdaley changed the title Improve markup and typography on "Request Review" modal Improve typography on "Request Review" modal Apr 15, 2024
@jeffdaley jeffdaley marked this pull request as ready for review April 15, 2024 16:33
@jeffdaley jeffdaley requested a review from a team as a code owner April 15, 2024 16:33
@jeffdaley jeffdaley merged commit e44e932 into main Apr 15, 2024
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/request-review branch April 15, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda