Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: 53 update ci workflows for best practices and standards #62

Merged
merged 48 commits into from
May 7, 2024
Merged

ci: 53 update ci workflows for best practices and standards #62

merged 48 commits into from
May 7, 2024

Conversation

rbarkerSL
Copy link
Contributor

Description:
This PR is intended to provide security and CI best practice updates to the github actions workflows.

This PR modifies files in the .github folder in order to support best practice updates

Related issue(s):

Fixes #53

Notes for reviewer:

Actions that don't run as part of a pull request are manually tested with a workflow-dispatch trigger prior to PR readiness.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

rbarkerSL added 7 commits April 5, 2024 14:23
@rbarkerSL rbarkerSL linked an issue Apr 24, 2024 that may be closed by this pull request
Update CI workflows for best practices and standards #53
Closed
@rbarkerSL rbarkerSL changed the title 53 update ci workflows for best practices and standards ci: 53 update ci workflows for best practices and standards Apr 24, 2024
rbarkerSL added 21 commits April 24, 2024 23:48
@rbarkerSL
Added workflow-dispatch triggers on the non-release workflows
8941112 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
updated dependabot
04ac6df 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Merge branch 'main' into 53-update-ci-workflows-for-best-practices-an…
3dfe687 
…d-standards

Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Updated the install for k3d.
6f63b78 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
reverted to using curl instead of brew
5ebcaf2 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Include kubectl
203fcfb 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Updated htg chart install file to bring in kubectl
2ae6039 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Playing with the lua install. Removed unnecessary workflow_dispatch:
fbb7c43 
triggers

Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Playing with the lua install further
e770dd9 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Manually calling sudo apt-get install on liblua
19822cd 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
manually installing lua 5.3 round 2
cb05150 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
round three lua install
d305f79 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Reverted to lua action
8d19352 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Selected the explicit latest of lua 5.3 (5.3.6)
7e345d1 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
manually prepping the lua install
4e4a4d1 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Updating apt-get first
a84ae07 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Playing with lua still :|
9961959 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
found issue with leafo/gh-actions-lua on self-hosted runner.
4578c27 
See issue leafo/gh-actions-lua#33.
Attempting manual install of lua

Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Added explicitly lua path for luarocks
c635bc6 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Updated lua path
901807c 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
added luac to manual install props
7067add 
Signed-off-by: Roger Barker <[email protected]>
rbarkerSL added 17 commits April 26, 2024 16:52
@rbarkerSL
added priority on sudo update-alternatives calls
ebcb437 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Removed lua alternative location
a4ef984 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Debug info added
2e1c668 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Using the path specified on which lua with lua -v
de601be 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
More debug
d180ffe 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
manually going after luarocks
9ed5144 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
luarocks install attempt #2
72cf3dd 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Verifiying luarocks info
94accd2 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Updated path to luarocks
a6ac5c1 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
run luarocks as sudoer
992c5bb 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Revisited how i'm pulling in lua
f0bb493 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Installing lua from source and luarocks
0f363ca 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Forgot to add the -y flag on the apt-get install
f5a7fe3 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
back to pulling lua from apt-get
fbd8d14 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
switched protocol from curl to wget
0436438 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
Playing with lua continues.
0416aa5 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL
adding liblua5.3-dev
b246169 
Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL rbarkerSL marked this pull request as ready for review April 27, 2024 01:13
@rbarkerSL rbarkerSL requested a review from a team as a code owner April 27, 2024 01:13
@rbarkerSL rbarkerSL self-assigned this Apr 27, 2024
Nana-EC
Nana-EC requested changes Apr 27, 2024
View reviewed changes
Copy link

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
A few items to clarify

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/workflows/proxy-tests.yml Show resolved Hide resolved
@rbarkerSL
Updates made per PR
6c9b9c5 
Signed-off-by: Roger Barker <[email protected]>
AlfredoG87
AlfredoG87 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 1 question.

.github/workflows/proxy-tests.yml Show resolved Hide resolved
.github/workflows/proxy-tests.yml Show resolved Hide resolved
@rbarkerSL rbarkerSL requested a review from Nana-EC May 6, 2024 16:11
Nana-EC
Nana-EC approved these changes May 7, 2024
View reviewed changes
Copy link

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@rbarkerSL rbarkerSL merged commit 39fbdc5 into main May 7, 2024
8 checks passed
@rbarkerSL rbarkerSL deleted the 53-update-ci-workflows-for-best-practices-and-standards branch May 7, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlfredoG87 AlfredoG87 AlfredoG87 approved these changes

@Nana-EC Nana-EC Nana-EC approved these changes

@david-bakin-sl david-bakin-sl Awaiting requested review from david-bakin-sl david-bakin-sl is a code owner automatically assigned from hashgraph/hedera-smart-contracts

@nathanklick nathanklick Awaiting requested review from nathanklick

Assignees

@rbarkerSL rbarkerSL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CI workflows for best practices and standards
3 participants
@rbarkerSL @Nana-EC @AlfredoG87