feat: add dry run parameter to /session/input-files and /session/verify-checked end-points #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-checked end-points. Signed-off-by: Simon Viénot <[email protected]>
svienot
force-pushed
the
add-dryrun-argument
branch
from
d7e1bab to
607346a
Compare
svienot
changed the title
svienot
requested review from
lukelee-sl,
Sheng-Long,
acuarica and
Nana-EC
and removed request for
a team
acuarica
reviewed
Dec 7, 2023
src/server/controllers/verification/session-state/input-files.session-state.paths.yaml
Show resolved
Hide resolved
src/server/controllers/verification/session-state/session-state.handlers.ts
Outdated
Show resolved
Hide resolved
…iles and /session/verify-checked end-points. Signed-off-by: Simon Viénot <[email protected]>
Signed-off-by: Simon Viénot <[email protected]>
Nana-EC
requested changes
Dec 7, 2023
src/server/controllers/verification/session-state/session-state.handlers.ts
Show resolved
Hide resolved
Confirmed offline with @svienot than manual confirmation was done and follow up PR will capture the rest |
Signed-off-by: Simon Viénot <[email protected]>
|
Issue capturing the need for API end-points regression tests: #93 |
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add optional
dryrunquery parameter to the 2 endpoints of the session API (/session/input-filesand/session/verify-checked) used by mirror-node explorer.When the parameter is present and set to true, the result of the (successful) verification is not stored in the repository.
Related issue(s):
Fixes #90