You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of maintaining our own fork of the verification service, use the images provided by upstream Sourcify directly. This will allow us to avoid duplicating efforts and incorporate new features easily.
For Hedera verification, we decided to directly consume server and repository images from Sourcify upstream. Given that the ui changes might be too Hedera specific, we decided to keep our ui fork with custom modifications.
Solution
The following is a list a features that upstream Sourcify should implement in order to use their images directly.
Problem
Instead of maintaining our own fork of the verification service, use the images provided by upstream Sourcify directly. This will allow us to avoid duplicating efforts and incorporate new features easily.
For Hedera verification, we decided to directly consume
server
andrepository
images from Sourcify upstream. Given that theui
changes might be too Hedera specific, we decided to keep ourui
fork with custom modifications.Solution
The following is a list a features that upstream Sourcify should implement in order to use their images directly.
Server image
dryrun
query parameter used in hashscan.io feat: add dry run parameter to /session/input-files and /session/verify-checked end-points #92 fix: typo in dryrun query parameter. #111 chore: add server tests for dryrun query parameter #112. Tracking issue Support for verification preview ethereum/sourcify#1319./metrics
feat: include support for metrics #131. Tracking issue Support for application metrics ethereum/sourcify#1320.servers
dropdown in OpenAPI docs fix: remove session endpoints and fix server drop-down #118. Tracking issue Support to customizeservers
dropdown in OpenAPI docs ethereum/sourcify#1345.Repository image (and
select-contract-form
UI)https://repository-verify.hashscan.io/select-contract/ vs https://repo.sourcify.dev/select-contract/
Allows users to lookup with non-checksummed addresses fix: repository lookup select contract form #100. Tracking issue Repository lookup not working with non-checksummed addresses ethereum/sourcify#1341.
Building image on Apple M-chips Fix building repository image on Apple M-chips #104
Customize Open repo in Remix link, i.e., either enable or disable it Error in verification after importing the contract into Remix #65
Fix default chain ID for during verification lookup Wrong chain ID for mainnet during verification lookups #64
UI image just for completion, we continue to use our own fork
https://verify.hashscan.io/ vs https://sourcify.dev/#/verifier
Given that it might be more difficult to push our customizations in the UI, we might keep our fork of the UI. Thus, these issues are less relevant.
Compatible terminology with mirror-node-explorer Replace 'perfect match' by 'full match' in UI #59
Removed the Sourcify landing page
Alternatives
No response
The text was updated successfully, but these errors were encountered: