Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: include PR title check workflow #114

Merged
merged 1 commit into from
Dec 20, 2023
Merged

chore: include PR title check workflow #114

merged 1 commit into from
Dec 20, 2023

Conversation

acuarica
Copy link
Contributor

Description:

This PR checks whether the PR title conforms with conventional commit message.

Related issue(s):

Fixes #113

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica
Include PR title check workflow
2d0255e 
Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica requested review from a team as code owners December 19, 2023 18:56
@acuarica acuarica requested a review from quiet-node December 19, 2023 18:56
@acuarica acuarica linked an issue Dec 19, 2023 that may be closed by this pull request
Should we include PR title check? #113
Closed
@acuarica acuarica requested review from Sheng-Long and removed request for a team December 19, 2023 18:56
svienot
svienot approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@acuarica acuarica merged commit 30adb61 into main Dec 20, 2023
8 checks passed
@acuarica acuarica deleted the 113-include-pr-title-check branch December 20, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

@quiet-node quiet-node Awaiting requested review from quiet-node quiet-node is a code owner automatically assigned from hashgraph/hedera-smart-contracts

@Sheng-Long Sheng-Long Awaiting requested review from Sheng-Long Sheng-Long is a code owner automatically assigned from hashgraph/dev-experience

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we include PR title check?
2 participants
@acuarica @svienot