New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we include PR title check? #113

Closed

acuarica opened this issue Dec 19, 2023 · 1 comment · Fixed by #114

Contributor

acuarica commented Dec 19, 2023

We started using conventional commits for PR titles, for example https://github.com/hashgraph/hedera-json-rpc-relay/blob/main/.github/workflows/flow-pr-title-check.yml.

Should we apply the same check here? @svienot @ericleponner @Nana-EC

Contributor

svienot commented Dec 19, 2023

It would probably be a good thing.

acuarica mentioned this issue

chore: include PR title check workflow #114

Merged

2 tasks

acuarica linked a pull request

that will close this issue

chore: include PR title check workflow #114

Merged

2 tasks

acuarica closed this as completed in #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment