Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (0.58) Support custom Operations in standalone executor #17354

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

tinker-michaelj
Copy link
Collaborator

Signed-off-by: Michael Tinker <[email protected]>
@tinker-michaelj tinker-michaelj requested review from a team as code owners January 13, 2025 16:00
@tinker-michaelj tinker-michaelj added this to the v0.59 milestone Jan 13, 2025
@tinker-michaelj tinker-michaelj self-assigned this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.35%. Comparing base (b208f7c) to head (343b0dc).
Report is 2 commits behind head on release/0.58.

Files with missing lines Patch % Lines
...app/workflows/standalone/TransactionExecutors.java 97.05% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.58   #17354      +/-   ##
==================================================
+ Coverage           64.34%   64.35%   +0.01%     
  Complexity          20914    20914              
==================================================
  Files                2549     2549              
  Lines               96007    96046      +39     
  Branches            10047    10048       +1     
==================================================
+ Hits                61773    61808      +35     
- Misses              30598    30601       +3     
- Partials             3636     3637       +1     
Files with missing lines Coverage Δ
...app/service/contract/impl/ContractServiceImpl.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v030/V030Module.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v034/V034Module.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v038/V038Module.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v046/V046Module.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v050/V050Module.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v051/V051Module.java 100.00% <100.00%> (ø)
...app/workflows/standalone/TransactionExecutors.java 93.40% <97.05%> (+1.88%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 97.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b208f7c) 95770 65217 68.10%
Head commit (343b0dc) 95809 (+39) 65253 (+36) 68.11% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17354) 43 42 97.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve hedera-node/hedera-app/build.gradle.kts

Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry pick LGTM

@tinker-michaelj tinker-michaelj merged commit ad53b0c into release/0.58 Jan 14, 2025
52 of 67 checks passed
@tinker-michaelj tinker-michaelj deleted the r58-cherry-pick-17329 branch January 14, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants