-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support block hash operation in modularized web3 #10148
Conversation
Signed-off-by: Steven Sheehy <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10148 +/- ##
============================================
+ Coverage 92.20% 92.30% +0.09%
+ Complexity 7896 7804 -92
============================================
Files 958 944 -14
Lines 33021 32801 -220
Branches 4170 4154 -16
============================================
- Hits 30447 30276 -171
+ Misses 1593 1549 -44
+ Partials 981 976 -5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Steven Sheehy <[email protected]>
...mirror-web3/src/main/java/com/hedera/mirror/web3/evm/properties/MirrorNodeEvmProperties.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/state/singleton/BlockInfoSingleton.java
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/common/ContractCallContext.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/service/ContractCallService.java
Show resolved
Hide resolved
Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
Quality Gate passedIssues Measures |
Looks great to me. From running the tests from main an here the only diff I see in the test result is ContractCallNativePrecompileTest here is getting THROTTLED_AT_CONSENSUS since on main are passing. |
THROTTLED_AT_CONSENSUS is usually due to lack of throttle definition. Let's get this then I can add the system file defaults as a follow up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
BlockInfo
singleton to return the last 256 block hashesRunningHashes
singleton to return the running hashMirrorOperationTracer
to modularized executionBlockInfo
laterVersionedConfiguration
once and use it everywhereTransactionExecutor
between requestscontracts.sidecars
to avoid generating unnecessary sidecar dataRelated issue(s):
Fixes #9983
Fixes #10149
Part of #10079
Notes for reviewer:
Before
After
Checklist