-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Support custom Set<Operation>
in standalone executor
#17329
Conversation
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17329 +/- ##
============================================
+ Coverage 67.41% 67.42% +0.01%
- Complexity 22064 22094 +30
============================================
Files 2585 2588 +3
Lines 96408 96634 +226
Branches 10071 10088 +17
============================================
+ Hits 64993 65157 +164
- Misses 27698 27752 +54
- Partials 3717 3725 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with the exception that maybe the solidity + json for EmitBlockTimestamp
contract needs to be added to the PR).
...vice-impl/src/main/java/com/hedera/node/app/service/contract/impl/annotations/CustomOps.java
Show resolved
Hide resolved
hedera-node/hedera-app/src/test/resources/initcode/EmitBlockTimestamp.bin
Show resolved
Hide resolved
.../hedera-app/src/main/java/com/hedera/node/app/workflows/standalone/TransactionExecutors.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review and approve hedera-node/hedera-app/build.gradle.kts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @tinker-michaelj
Description:
Operation
s in standalone executor #17323