Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Support custom Set<Operation> in standalone executor #17329

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj requested review from a team as code owners January 10, 2025 21:03
@tinker-michaelj tinker-michaelj added this to the v0.58 milestone Jan 10, 2025
@tinker-michaelj tinker-michaelj self-assigned this Jan 10, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 97.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (02ba8df) 96191 68558 71.27%
Head commit (305d92b) 96349 (+158) 68662 (+104) 71.26% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17329) 43 42 97.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.42%. Comparing base (02ba8df) to head (305d92b).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...app/workflows/standalone/TransactionExecutors.java 97.05% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17329      +/-   ##
============================================
+ Coverage     67.41%   67.42%   +0.01%     
- Complexity    22064    22094      +30     
============================================
  Files          2585     2588       +3     
  Lines         96408    96634     +226     
  Branches      10071    10088      +17     
============================================
+ Hits          64993    65157     +164     
- Misses        27698    27752      +54     
- Partials       3717     3725       +8     
Files with missing lines Coverage Δ
...app/service/contract/impl/ContractServiceImpl.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v030/V030Module.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v034/V034Module.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v038/V038Module.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v046/V046Module.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v050/V050Module.java 100.00% <100.00%> (ø)
...pp/service/contract/impl/exec/v051/V051Module.java 100.00% <100.00%> (ø)
...app/workflows/standalone/TransactionExecutors.java 93.02% <97.05%> (+2.28%) ⬆️

... and 7 files with indirect coverage changes

Impacted file tree graph

Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with the exception that maybe the solidity + json for EmitBlockTimestamp contract needs to be added to the PR).

Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve hedera-node/hedera-app/build.gradle.kts

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tinker-michaelj

@tinker-michaelj tinker-michaelj merged commit 8c9930a into main Jan 13, 2025
54 of 55 checks passed
@tinker-michaelj tinker-michaelj deleted the 17323-custom-standalone-evm-ops branch January 13, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support registering custom EVM Operations in standalone executor
7 participants