-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove copied proto src #123
Open
jasperpotts
wants to merge
6
commits into
replace-maven-with-gradle
Choose a base branch
from
remove-copied-proto-src
base: replace-maven-with-gradle
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e71b96a
Replaced src dir with auto clone hedera-protobufs repo
jasperpotts e7f3474
Removed docs as they are not useful any more
jasperpotts f694b8d
Clean up of readme and instructions
jasperpotts 8db2949
Attempt to fix circle ci
jasperpotts ad5ee03
Fix protoc for circleci
jasperpotts 657e22c
Fixed config so it is all done in gradle.properties
jasperpotts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
version = "0.13.0-alpha.4-SNAPSHOT" | ||
version = "0.13.0-alpha.4-SNAPSHOT" | ||
hapiVersion = "v0.31.0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,27 @@ | ||
import me.champeau.gradle.igp.gitRepositories | ||
|
||
rootProject.name = "hedera-protobuf-java-api" | ||
|
||
// Add local maven build directory to plugin repos | ||
pluginManagement { | ||
repositories { | ||
gradlePluginPortal() | ||
mavenCentral() | ||
} | ||
} | ||
|
||
// Use GIT plugin to clone HAPI protobuf files | ||
// See documentation https://melix.github.io/includegit-gradle-plugin/latest/index.html | ||
plugins { | ||
id("me.champeau.includegit") version "0.1.5" | ||
} | ||
gitRepositories { | ||
include("hedera-protobufs") { | ||
autoInclude.set(false) | ||
uri.set("https://github.com/hashgraph/hedera-protobufs.git") | ||
// optional, set what branch to use | ||
// branch.set("main") | ||
// you can also use a tag | ||
tag.set("v0.31.0") | ||
} | ||
} | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to actually use the
hapiVersion
property.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cleaned up those, I could not us hapiVersion as seems like settings happens before properties file is loaded. So I updated comments in code and updated README explaining