Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copied proto src #123

Open
wants to merge 6 commits into
base: replace-maven-with-gradle
Choose a base branch
from

Conversation

jasperpotts
Copy link
Member

Removing copied protobuf sources, now clones hedera-protos repo during build. Depends on pull request #122

@jasperpotts jasperpotts changed the base branch from main to replace-maven-with-gradle November 12, 2022 02:14
Comment on lines 18 to 27
gitRepositories {
include("hedera-protobufs") {
autoInclude.set(false)
uri.set("https://github.com/hashgraph/hedera-protobufs.git")
// optional, set what branch to use
// branch.set("main")
// you can also use a tag
tag.set("v0.31.0")
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to actually use the hapiVersion property.

Suggested change
gitRepositories {
include("hedera-protobufs") {
autoInclude.set(false)
uri.set("https://github.com/hashgraph/hedera-protobufs.git")
// optional, set what branch to use
// branch.set("main")
// you can also use a tag
tag.set("v0.31.0")
}
}
val hapiVersion by project
gitRepositories {
include("hedera-protobufs") {
autoInclude.set(false)
uri.set("https://github.com/hashgraph/hedera-protobufs.git")
// optional, set what branch to use
// branch.set("main")
// you can also use a tag
tag.set(hapiVersion)
}
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned up those, I could not us hapiVersion as seems like settings happens before properties file is loaded. So I updated comments in code and updated README explaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants