-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove copied proto src #123
base: replace-maven-with-gradle
Are you sure you want to change the base?
Conversation
Signed-off-by: jasperpotts <[email protected]>
settings.gradle.kts
Outdated
gitRepositories { | ||
include("hedera-protobufs") { | ||
autoInclude.set(false) | ||
uri.set("https://github.com/hashgraph/hedera-protobufs.git") | ||
// optional, set what branch to use | ||
// branch.set("main") | ||
// you can also use a tag | ||
tag.set("v0.31.0") | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to actually use the hapiVersion
property.
gitRepositories { | |
include("hedera-protobufs") { | |
autoInclude.set(false) | |
uri.set("https://github.com/hashgraph/hedera-protobufs.git") | |
// optional, set what branch to use | |
// branch.set("main") | |
// you can also use a tag | |
tag.set("v0.31.0") | |
} | |
} | |
val hapiVersion by project | |
gitRepositories { | |
include("hedera-protobufs") { | |
autoInclude.set(false) | |
uri.set("https://github.com/hashgraph/hedera-protobufs.git") | |
// optional, set what branch to use | |
// branch.set("main") | |
// you can also use a tag | |
tag.set(hapiVersion) | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cleaned up those, I could not us hapiVersion as seems like settings happens before properties file is loaded. So I updated comments in code and updated README explaining
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Removing copied protobuf sources, now clones hedera-protos repo during build. Depends on pull request #122