Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gradle tasks from different subproject are not isolated #337

Merged
merged 15 commits into from
Nov 19, 2024
Merged

fix: gradle tasks from different subproject are not isolated #337

merged 15 commits into from
Nov 19, 2024

Conversation

ata-nas
Copy link
Contributor

@ata-nas ata-nas commented Nov 12, 2024

Description:

Isolate gradle tasks to not go outside of the respective project's build root.

Related issue(s):

Fixes #299

Notes for reviewer:

  • am I missing something?

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ata-nas ata-nas added Bug A error that causes the feature to behave differently than what was expected based on design docs Block Node Issues/PR related to the Block Node. labels Nov 12, 2024
@ata-nas ata-nas added this to the 0.3.0 milestone Nov 12, 2024
@ata-nas ata-nas self-assigned this Nov 12, 2024
@ata-nas ata-nas linked an issue Nov 12, 2024 that may be closed by this pull request
fix: gradle tasks from different subproject are not isolated #299
Closed
@ata-nas ata-nas changed the title bug: gradle tasks from different subproject are not isolated fix: gradle tasks from different subproject are not isolated Nov 12, 2024
@ata-nas ata-nas marked this pull request as ready for review November 12, 2024 12:38
@ata-nas ata-nas requested review from a team as code owners November 12, 2024 12:38
@ata-nas ata-nas force-pushed the 299-bug-gradle-tasks-from-different-subproject-are-not-isolated branch from e3e75cc to 66d7417 Compare November 13, 2024 07:53
@ata-nas ata-nas requested a review from a team as a code owner November 13, 2024 12:12
@ata-nas ata-nas marked this pull request as draft November 13, 2024 12:25
@ata-nas ata-nas marked this pull request as ready for review November 13, 2024 14:39
mishomihov00
mishomihov00 previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved only these files:
.github/workflows/e2e-tests.yaml
.github/workflows/smoke-test.yaml
server/docker/docker-build.sh
server/docker/docker-compose.yml
server/docker/update-env.sh

@ata-nas ata-nas force-pushed the 299-bug-gradle-tasks-from-different-subproject-are-not-isolated branch from 581174f to e94e061 Compare November 14, 2024 08:00
@ata-nas ata-nas mentioned this pull request Nov 14, 2024
Open
@ata-nas ata-nas requested a review from mishomihov00 November 14, 2024 08:33
mishomihov00
mishomihov00 previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved only these files:
.github/workflows/e2e-tests.yaml
.github/workflows/smoke-test.yaml
server/docker/docker-build.sh
server/docker/docker-compose.yml
server/docker/update-env.sh

georgi-l95
georgi-l95 previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ 👍 👉 👨‍💻

jeromy-cannon
jeromy-cannon previously approved these changes Nov 18, 2024
View reviewed changes
jeromy-cannon
jeromy-cannon previously approved these changes Nov 18, 2024
View reviewed changes
rbarkerSL
rbarkerSL previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ata-nas added 15 commits November 19, 2024 09:35
@ata-nas
isolating the updateDockerEnv task to build root
c054cdb 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
providing the new .env file location
7ced7b3 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
spotlessApply
993d34a 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
some javadoc
6ee9a72 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
.gitignore revert unintentional deletion
128bddc 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
addressing pr comment
ac3f188 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
spotlessApply
b3cc77b 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
generating .env is now responsibility of the respective start command
67472b9 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
minor bugfix, removal of unused field and spotlessApply
5f6ae56 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
rename field to improve semantics
e0e04bc 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
some temporary fixes for the suites
6297899 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
spotlessApply
b4de134 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
stop the smoke test container from docker task
f054f63 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
tagging todos for the future
aa4003b 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
typo
710554c 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas ata-nas dismissed stale reviews from rbarkerSL and jeromy-cannon via 710554c November 19, 2024 07:39
@ata-nas ata-nas force-pushed the 299-bug-gradle-tasks-from-different-subproject-are-not-isolated branch from 0dc75b4 to 710554c Compare November 19, 2024 07:39
@ata-nas ata-nas merged commit ad18213 into main Nov 19, 2024
15 checks passed
@ata-nas ata-nas deleted the 299-bug-gradle-tasks-from-different-subproject-are-not-isolated branch November 19, 2024 12:01
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@46ad591). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage        ?   94.62%           
  Complexity      ?      316           
=======================================
  Files           ?       69           
  Lines           ?     1228           
  Branches        ?       84           
=======================================
  Hits            ?     1162           
  Misses          ?       55           
  Partials        ?       11
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishomihov00 mishomihov00 mishomihov00 approved these changes

@georgi-l95 georgi-l95 georgi-l95 approved these changes

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner automatically assigned from hashgraph/devops-ci

@jsync-swirlds jsync-swirlds Awaiting requested review from jsync-swirlds

@rbarkerSL rbarkerSL Awaiting requested review from rbarkerSL

Assignees

@ata-nas ata-nas

Labels
Block Node Issues/PR related to the Block Node. Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

fix: gradle tasks from different subproject are not isolated
6 participants
@ata-nas @jeromy-cannon @georgi-l95 @jsync-swirlds @rbarkerSL @mishomihov00