Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gradle tasks from different subproject are not isolated #299

Closed
ata-nas opened this issue Oct 23, 2024 · 3 comments · Fixed by #337
Closed

fix: gradle tasks from different subproject are not isolated #299

ata-nas opened this issue Oct 23, 2024 · 3 comments · Fixed by #337
Assignees
Labels
Block Node Issues/PR related to the Block Node. Bug A error that causes the feature to behave differently than what was expected based on design docs
Milestone

Comments

@ata-nas
Copy link
Contributor

ata-nas commented Oct 23, 2024

What Happened

Due to some concerns that arose in #264, there are repeating task names createDockerImage (outside the scope of the issue, but inside the scope of the discussion #264) which do touch on a common file that gets created via a shell script update-env and in the asynchronous nature of the running of the tasks, it could happen that a project gets build with the wrong values that come from the common .env file.

What should happen

All tasks (especially those that have the same task names) must run in an isolated fashion, not going outside the subproject build root.
Subprojects may share common scripts and files, but must not write files outside the current subproject build root. Copying inputs or scripts between subprojects is acceptable if this improves task isolation.

@ata-nas ata-nas added Bug A error that causes the feature to behave differently than what was expected based on design docs Block Node Issues/PR related to the Block Node. labels Oct 23, 2024
@ata-nas ata-nas added this to the 0.2.0 milestone Oct 23, 2024
@AlfredoG87
Copy link
Contributor

@ata-nas can we close this one too?

@ata-nas
Copy link
Contributor Author

ata-nas commented Nov 11, 2024

@ata-nas can we close this one too?

@AlfredoG87 we cannot close this one, it is the result of the #264 discussion. We have non-deterministic behavior, since we have files that are being produced by the tasks which go outside the respective build root. This must be fixed and to be ensured that it will no longer be the case.

That being said, maybe #332 may be a duplicate of this one and could be closed?

@ata-nas ata-nas linked a pull request Nov 12, 2024 that will close this issue
2 tasks
@ata-nas ata-nas modified the milestones: 0.2.0, 0.3.0 Nov 12, 2024
@ata-nas ata-nas changed the title bug: gradle tasks from different subproject are not isolated fix: gradle tasks from different subproject are not isolated Nov 12, 2024
@AlfredoG87
Copy link
Contributor

@ata-nas can we close this one too?

@AlfredoG87 we cannot close this one, it is the result of the #264 discussion. We have non-deterministic behavior, since we have files that are being produced by the tasks which go outside the respective build root. This must be fixed and to be ensured that it will no longer be the case.

That being said, maybe #332 may be a duplicate of this one and could be closed?

Is not a duplicate, I don't think the gradle tasks being isolated is the same as docker image being built deterministically.
lets keep both open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node. Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants