Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use common Hiero Gradle config #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: use common Hiero Gradle config #216

wants to merge 1 commit into from

Conversation

jjohannes
Copy link
Contributor

@jjohannes jjohannes commented Sep 26, 2024 •
edited
Loading

Description:

Before this can be integrated:

  • Publish hiero-gradle-conventions plugins to Gradle Plugin Portal and use from there

Related issue(s):

hashgraph/hedera-services#14255

@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 7714646 to 222c26c Compare October 8, 2024 07:35
@jjohannes jjohannes self-assigned this Oct 8, 2024
@jjohannes jjohannes added the P3 Low priority issue. Will not impact the release schedule if not complete. label Oct 8, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 3 times, most recently from ca2a5a2 to ffd5207 Compare October 8, 2024 09:46
@jjohannes jjohannes mentioned this pull request Oct 8, 2024
Closed
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 5 times, most recently from e91163b to a6fa9da Compare October 16, 2024 07:06
@jjohannes jjohannes changed the title build: use common Hedera Gradle config build: use common Hiero Gradle config Nov 4, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from a6fa9da to 84eb4d2 Compare November 4, 2024 15:22
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 3 times, most recently from e2d53b8 to 17a484d Compare December 11, 2024 14:30
@jjohannes jjohannes added this to the 0.4.0 milestone Dec 11, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 17a484d to 1126d25 Compare December 11, 2024 14:48
@jjohannes jjohannes marked this pull request as ready for review December 11, 2024 14:56
@jjohannes jjohannes requested review from a team as code owners December 11, 2024 14:56
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 1126d25 to 65f8772 Compare December 11, 2024 14:59
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 65f8772 to e783e1d Compare December 11, 2024 15:03
mishomihov00
mishomihov00 previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to .github/dependabot.yml and .github/workflows/pr-checks.yaml

rbarkerSL
rbarkerSL requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question. Prefer to avoid storing binaries if we can avoid it.

gradle/wrapper/gradle-wrapper.jar Outdated Show resolved Hide resolved
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from e783e1d to 1ece81f Compare December 19, 2024 08:04
@jjohannes jjohannes requested a review from rbarkerSL December 19, 2024 08:05
@jjohannes
build: use common Gradle config
f574b1a 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 1ece81f to f574b1a Compare December 19, 2024 08:31
mattp-swirldslabs
mattp-swirldslabs reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jendrik, I need to merge in our implementation of the deterministic build and deterministic images before you merge this PR. Is that ok?

@jjohannes
Copy link
Contributor Author

@mattp-swirldslabs sure go ahead.
I am taking some days off for the holidays. I won't get back to this before January anyway.
I will deal with potential conflicts then if there are any.

@jjohannes jjohannes mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsync-swirlds jsync-swirlds jsync-swirlds left review comments

@mattp-swirldslabs mattp-swirldslabs mattp-swirldslabs left review comments

@mishomihov00 mishomihov00 mishomihov00 left review comments

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

@rbarkerSL rbarkerSL Awaiting requested review from rbarkerSL

Requested changes must be addressed to merge this pull request.

Assignees

@jjohannes jjohannes

Labels
P3 Low priority issue. Will not impact the release schedule if not complete.
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jjohannes @mattp-swirldslabs @jsync-swirlds @rbarkerSL @mishomihov00