Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Java 21.0.5 #453

Closed
jjohannes opened this issue Jan 9, 2025 · 2 comments · Fixed by #425
Closed

Update to Java 21.0.5 #453

jjohannes opened this issue Jan 9, 2025 · 2 comments · Fixed by #425

Comments

@jjohannes
Copy link
Collaborator

Wait for #216 to be merged first

Version needs to be updated in all places in the GH Action workflows and in gradle/toolchain-versions.properties!
@jjohannes jjohannes mentioned this issue Jan 9, 2025
Merged
1 task
@mattp-swirldslabs
Copy link
Contributor

Hi Jendrik, my determinism PR is almost through the review process. I updated the gradle java version in there too.

@jjohannes
Copy link
Collaborator Author

@mattp-swirldslabs thanks for letting me know. Then your PR will resolve this issue.

Note that the version that is picked up by Gradle has just moved here:
https://github.com/hashgraph/hedera-block-node/blob/main/gradle/toolchain-versions.properties#L1

Sorry for creating this last minute conflict.

@jjohannes jjohannes linked a pull request Jan 9, 2025 that will close this issue
feat: Deterministic Gradle build #425
Merged
2 tasks
@jjohannes jjohannes mentioned this issue Jan 10, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Deterministic Gradle build hashgraph/hedera-block-node
2 participants
@jjohannes @mattp-swirldslabs