Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deterministic Gradle build #425

Merged
merged 29 commits into from
Jan 10, 2025
Merged

feat: Deterministic Gradle build #425

merged 29 commits into from
Jan 10, 2025

Conversation

mattp-swirldslabs
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs commented Dec 18, 2024 •
edited by jjohannes
Loading

Description:

  • Added deterministic gradle build
  • Added deterministic docker container build
  • Updated to 21.0.5+11

Related issue(s):

Fixes #408
Fixes #409
Fixes #410
Fixes #453

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mattp-swirldslabs mattp-swirldslabs added the Block Node Issues/PR related to the Block Node. label Dec 18, 2024
@mattp-swirldslabs mattp-swirldslabs added this to the 0.4.0 milestone Dec 18, 2024
@mattp-swirldslabs mattp-swirldslabs self-assigned this Dec 18, 2024
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00408-deterministic-gradle-changes-3 branch 3 times, most recently from a71e25f to d58059b Compare January 6, 2025 21:08
@mattp-swirldslabs mattp-swirldslabs marked this pull request as ready for review January 6, 2025 23:16
@mattp-swirldslabs mattp-swirldslabs requested review from a team as code owners January 6, 2025 23:16
ata-nas
ata-nas reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on first pass.

.github/workflows/support/scripts/generate-docker-artifact-baseline.sh Outdated Show resolved Hide resolved
.github/workflows/support/scripts/generate-docker-artifact-baseline.sh Outdated Show resolved Hide resolved
server/docker/repro-sources-list.sh Outdated Show resolved Hide resolved
server/docker/repro-sources-list.sh Outdated Show resolved Hide resolved
.github/workflows/support/scripts/generate-docker-artifact-baseline.sh Outdated Show resolved Hide resolved
mishomihov00
mishomihov00 previously approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies only to the *.yaml files.

@mattp-swirldslabs mattp-swirldslabs force-pushed the 00408-deterministic-gradle-changes-3 branch from c1deb88 to d825919 Compare January 7, 2025 19:50
ata-nas
ata-nas previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattp-swirldslabs mattp-swirldslabs force-pushed the 00408-deterministic-gradle-changes-3 branch from 3e8381e to 7ef57c7 Compare January 8, 2025 11:37
AlfredoG87
AlfredoG87 previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! Thank you!!
LGTM

ata-nas
ata-nas previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LG!

@mattp-swirldslabs
fix: gradle and docker determinism working
423afc3 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: trimmed out debugging info
cb33f74 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
Removed GH Container Registry directives
e39cdbb 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
Enabling other supported linux versions
a88c4b6 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
Removed other linux version as they are not supported in hedera-servi…
10338a1 
…ces currently

Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: updated to use java 21.0.5+11
d71e491 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
Fixed missing ESUM
2b4028a 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
Use the dynamic tag
bd2283d 
Signed-off-by: Matt Peterson <[email protected]>
jjohannes
jjohannes previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@jjohannes jjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for Gradle and Yaml changes

@jjohannes
ci: fix new extract version steps
4bc480d 
Signed-off-by: Jendrik Johannes <[email protected]>
jjohannes
jjohannes previously approved these changes Jan 10, 2025
View reviewed changes
jjohannes
jjohannes previously approved these changes Jan 10, 2025
View reviewed changes
AlfredoG87
AlfredoG87 previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ata-nas
ata-nas previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nathanklick
nathanklick reviewed Jan 10, 2025
View reviewed changes
server/docker/Dockerfile Show resolved Hide resolved
server/docker/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/zxc-verify-docker-build-determinism.yaml Outdated Show resolved Hide resolved
.github/workflows/zxc-verify-docker-build-determinism.yaml Outdated Show resolved Hide resolved
rbarkerSL
rbarkerSL previously approved these changes Jan 10, 2025
View reviewed changes
nathanklick
nathanklick previously approved these changes Jan 10, 2025
View reviewed changes
@mattp-swirldslabs mattp-swirldslabs mentioned this pull request Jan 10, 2025
Closed
2 tasks
@mattp-swirldslabs mattp-swirldslabs merged commit 74240cb into main Jan 10, 2025
19 checks passed
@mattp-swirldslabs mattp-swirldslabs deleted the 00408-deterministic-gradle-changes-3 branch January 10, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlfredoG87 AlfredoG87 AlfredoG87 approved these changes

@nathanklick nathanklick nathanklick approved these changes

@rbarkerSL rbarkerSL rbarkerSL left review comments

@ata-nas ata-nas ata-nas left review comments

@jjohannes jjohannes jjohannes left review comments

@andrewb1269hg andrewb1269hg Awaiting requested review from andrewb1269hg andrewb1269hg is a code owner automatically assigned from hashgraph/devops-ci

@mishomihov00 mishomihov00 Awaiting requested review from mishomihov00

Assignees

@mattp-swirldslabs mattp-swirldslabs

Labels
Block Node Issues/PR related to the Block Node.
Projects
None yet
Milestone
0.4.0
7 participants
@mattp-swirldslabs @jjohannes @nathanklick @ata-nas @AlfredoG87 @rbarkerSL @mishomihov00