Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error page #301

Merged
merged 2 commits into from
Dec 16, 2023
Merged

feat: error page #301

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
245eee9
feat: error page
NoamGaash Dec 14, 2023
fdac832
fix: apply error boundary to all pages
NoamGaash Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/locale/he.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,5 +114,11 @@
"lineProfile": {
"title": "פרופיל קו",
"notFound":"לא הצלחנו למצוא את הקו שחיפשת :("
},
"errorPage": {
"title": "אופס, משהו השתבש",
"text": "אנא נסה שוב מאוחר יותר",
"text2": "אם הבעיה נמשכת, אנא פנה אלינו בכתובת:",
"button": "חזרה לדף הבית"
}
}
27 changes: 27 additions & 0 deletions src/pages/ErrorPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { useTranslation } from 'react-i18next'
import styled from 'styled-components'

const Centered = styled.div`
text-align: center;
`

export const ErrorPage = () => {
const { t } = useTranslation()
return (
<Centered>
<h1>{t('errorPage.title')}</h1>
<section>
<p>{t('errorPage.text')}</p>
<br />
<img src="https://media0.giphy.com/media/YcLorQZbPI4Ks/giphy.gif" alt="error" />
<br />
<p>
{t('errorPage.text2')} <br />
<a href="https://github.com/hasadna/open-bus-map-search/issues/new">
https://github.com/hasadna/open-bus-map-search/issues/new
</a>
</p>
</section>
</Centered>
)
}
2 changes: 2 additions & 0 deletions src/routes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
LineChartOutlined,
} from '@ant-design/icons'
import { MainRoute } from './MainRoute'
import { ErrorPage } from 'src/pages/ErrorPage'

export const PAGES = [
{
Expand Down Expand Up @@ -96,6 +97,7 @@ const getRoutesList = () => {
path="/profile/:gtfsRideGtfsRouteId"
key={'/profile/:gtfsRideGtfsRouteId'}
element={<Profile />}
ErrorBoundary={ErrorPage}
Copy link
Collaborator

@ArkadiK94 ArkadiK94 Dec 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is it the only route that we should add ErrorBoundary?
Not looks like it, I changed the VITE_BASE_PATH to be an uncorrect path and still I don't see any data and there is an error in the console...
image
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant even when the backend is off , this error page is not displayed. From first look of it, we don't catch errors from axios requests. Up to you, if you would like to do it as part of this pr or we can clarify it in the issue that this is left to do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea actually.
This error boundary build for handling js exceptions rather than network errors, but it's definitely something we should consider

loader={async ({ params: { gtfsRideGtfsRouteId } }) => {
const resp = await fetch(
`https://open-bus-stride-api.hasadna.org.il/gtfs_routes/get?id=${gtfsRideGtfsRouteId}`,
Expand Down
Loading