feat: error page #301
Merged
feat: error page #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArkadiK94
requested changes
Dec 16, 2023
| @@ -96,6 +97,7 @@ const getRoutesList = () => { | |||
| path="/profile/:gtfsRideGtfsRouteId" | |||
| key={'/profile/:gtfsRideGtfsRouteId'} | |||
| element={<Profile />} | |||
| ErrorBoundary={ErrorPage} | |||
There was a problem hiding this comment.
Hmm, is it the only route that we should add ErrorBoundary?
Not looks like it, I changed the VITE_BASE_PATH to be an uncorrect path and still I don't see any data and there is an error in the console...
There was a problem hiding this comment.
I meant even when the backend is off , this error page is not displayed. From first look of it, we don't catch errors from axios requests. Up to you, if you would like to do it as part of this pr or we can clarify it in the issue that this is left to do.
There was a problem hiding this comment.
That's a great idea actually.
This error boundary build for handling js exceptions rather than network errors, but it's definitely something we should consider
ArkadiK94
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#273
screenshots