Improve linter #166
Improve linter #166
Conversation
# Conflicts: # yarn.lock
✅ Deploy Preview for astonishing-pothos-5f81bd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
after falling since there is unused import in node modules anyway the project clean from unused export/import if you want to put back in linter you should change and at |
.eslintrc.json
Outdated
| "@typescript-eslint/no-unused-vars": "off", | ||
| "react/react-in-jsx-scope": "off", |
There was a problem hiding this comment.
please find a solution so we'll get errors / warning whenever we have unused variable
There was a problem hiding this comment.
changed to "error"
tsconfig.json
Outdated
| @@ -9,6 +9,7 @@ | |||
| "allowJs": false, | |||
| "skipLibCheck": true, | |||
| "esModuleInterop": true, | |||
| "noUnusedLocals": false, | |||
There was a problem hiding this comment.
when you change it to true it raise an error on unused variables
There was a problem hiding this comment.
ok so i remove it.
stay only with linter.
then node modules not make a problem
| "plugins": ["react", "@typescript-eslint"], | ||
| "rules": { | ||
| "@typescript-eslint/no-non-null-assertion": "off", | ||
| "@typescript-eslint/no-unused-vars": "error", | ||
| "react/react-in-jsx-scope": "off", |
There was a problem hiding this comment.
I learned something new
https://dev.to/titungdup/you-no-longer-need-to-import-react-from-react-3pbj
Description
this to resolve #160 issue
clean all unused code with ts-prune
and remove unused export.
add ci in lint check for circular dependencies
add for linter not allowed unused code like
"@typescript-eslint/no-unused-vars": "error",
that was mostly react import so I also add this
"react/react-in-jsx-scope": "off",