-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add storybook #196
feat: add storybook #196
Conversation
✅ Deploy Preview for astonishing-pothos-5f81bd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -0,0 +1,23 @@ | |||
import type { Preview } from '@storybook/react' | |||
import React from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused import plz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://dev.to/titungdup/you-no-longer-need-to-import-react-from-react-3pbj
in this pr i changed it and it's works for me without this import
#166
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't work in the storybook thingy. maybe the TS version isn't up to date. it can be improved in future PR
yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure you want this in your commit
(in my experience usually it's just a change on your local computer but you don't wont to commit it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added 2 small comments it looks nice and works for me! maybe you want to add also for redme |
@giladfuchs if you think it can be merged - please click "approve" |
Description
Only one story (for now)
screenshots