Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add storybook #196

Merged
merged 3 commits into from
Nov 13, 2023
Merged

feat: add storybook #196

merged 3 commits into from
Nov 13, 2023

Conversation

NoamGaash
Copy link
Member

Description

Only one story (for now)

screenshots

image

Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for astonishing-pothos-5f81bd ready!

Name Link
🔨 Latest commit 301f33d
🔍 Latest deploy log https://app.netlify.com/sites/astonishing-pothos-5f81bd/deploys/6552352c7fd0d10008c7a359
😎 Deploy Preview https://deploy-preview-196--astonishing-pothos-5f81bd.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NoamGaash NoamGaash requested a review from shootermv November 11, 2023 12:29
@@ -0,0 +1,23 @@
import type { Preview } from '@storybook/react'
import React from 'react'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused import plz

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dev.to/titungdup/you-no-longer-need-to-import-react-from-react-3pbj

in this pr i changed it and it's works for me without this import
#166

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work in the storybook thingy. maybe the TS version isn't up to date. it can be improved in future PR

yarn.lock Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you want this in your commit

(in my experience usually it's just a change on your local computer but you don't wont to commit it)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giladfuchs
Copy link
Collaborator

I just added 2 small comments it looks nice and works for me!

maybe you want to add also for redme
npm run storybook
or whatever for know of this feature

@NoamGaash
Copy link
Member Author

@giladfuchs if you think it can be merged - please click "approve"
documentation and CI/CD plans could be done on another PR

@NoamGaash NoamGaash requested a review from giladfuchs November 13, 2023 14:16
@NoamGaash NoamGaash merged commit c29b7f2 into main Nov 13, 2023
11 checks passed
@NoamGaash NoamGaash deleted the feat/add-storybook branch November 13, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants