Feature/clear input button #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: make it easily to the user change the line number How: by using IconButton (with ClearIcon) and placing in the right placeholder What: add ClearButton in LineSelector component
…imelinePage How: Check if the lineNumber or operatorId is not undefined and stop the other effects from running
…apsPatternsPage and SingleLineMapPage How: Check if the lineNumber or operatorId is not undefined , reset the routeKey and routes
NoamGaash
approved these changes
Oct 24, 2023
shootermv
reviewed
Oct 24, 2023
…n-bus-map-search into feature/clear-input-button
|
please resolve conflicts |
✅ Deploy Preview for astonishing-pothos-5f81bd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What: Add tests to make sure that the clear button works Why: To be sure that future changes will not affect its functionality How: using playwright
|
@NoamGaash, I added tests of the clear button. |
NoamGaash
approved these changes
Oct 28, 2023
NoamGaash
requested changes
Oct 28, 2023
NoamGaash
reviewed
Oct 28, 2023
NoamGaash
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves issue #59
[Feature] Add ClearButton To LineSelector
Why: make it easily to the user change the line number
How: by using IconButton (with ClearIcon) and placing in the right placeholder
What: add ClearButton in LineSelector component
Reset the routeKey and routes values when clearing the operatorId or lineNumber
screenshots
<-- paste here -->
Recording.2023-10-23.225958.mp4