Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reset button to user input #59

Closed
ArkadiK94 opened this issue Sep 20, 2023 · 8 comments · Fixed by #151
Closed

Add reset button to user input #59

ArkadiK94 opened this issue Sep 20, 2023 · 8 comments · Fixed by #151
Assignees

Comments

@ArkadiK94
Copy link
Collaborator

In some pages like GapsPage and TimelinePage, I think it will be a better user experience to add a reset button. When the user would like to change the selected bus number he/she will click this button and the inputs will be removed/change to the default input. What do you think about this? @ShayAdler @NoamGaash

@NoamGaash
Copy link
Member

I think it's a good idea - but what the default value should be? empty state isn't very useful

@ArkadiK94
Copy link
Collaborator Author

About the date, the default value will be today. Why is empty state not so useful? 🤔 I am not sure about the default values for the rest of the inputs.

@NoamGaash
Copy link
Member

I think we shouldn't be opinionated regarding default values for fields like "operator" (מפעיל)

@ArkadiK94
Copy link
Collaborator Author

ArkadiK94 commented Sep 21, 2023

I think so as well. In my opinion, we can reset the values to empty state , and only for the date reset it to today. However, you said that empty state is not useful. I can implement this button in this way, and if we will see a problem with that change it later. What do you think?

@NoamGaash
Copy link
Member

Let's think of the problem, before jumping into solutions..
What's the use case for such a button? How does it help to the final user experience?
Did you suggested this idea because you considered a use case of a user that wants to change the operator they are searching, and feels frustration due to the need to delete the content of the input element when focused?

@ArkadiK94
Copy link
Collaborator Author

ArkadiK94 commented Sep 22, 2023

Yes, the user needs not only to change the operator but also the line number and date from the last search, so I think it is easier for the user to remove those inputs and select/write new ones from blank.

@ArkadiK94
Copy link
Collaborator Author

Hi, I noticed something, in some input fields we have a "clear" X button in the input field , for example in "OperatorSelector" "RouteSelector" like in the image
image

Instead of making a separate button to reset values we can add this functionality in/beside the "LineNumberSelector" and "MinuteSelector" input fields
image

What do you think? @NoamGaash

@NoamGaash
Copy link
Member

I think it's a much better idea, thanks!

@ArkadiK94 ArkadiK94 self-assigned this Oct 21, 2023
@ArkadiK94 ArkadiK94 linked a pull request Oct 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants