-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reset button to user input #59
Comments
I think it's a good idea - but what the default value should be? empty state isn't very useful |
About the date, the default value will be today. Why is empty state not so useful? 🤔 I am not sure about the default values for the rest of the inputs. |
I think we shouldn't be opinionated regarding default values for fields like "operator" (מפעיל) |
I think so as well. In my opinion, we can reset the values to empty state , and only for the date reset it to today. However, you said that empty state is not useful. I can implement this button in this way, and if we will see a problem with that change it later. What do you think? |
Let's think of the problem, before jumping into solutions.. |
Yes, the user needs not only to change the operator but also the line number and date from the last search, so I think it is easier for the user to remove those inputs and select/write new ones from blank. |
Hi, I noticed something, in some input fields we have a "clear" X button in the input field , for example in "OperatorSelector" "RouteSelector" like in the image Instead of making a separate button to reset values we can add this functionality in/beside the "LineNumberSelector" and "MinuteSelector" input fields What do you think? @NoamGaash |
I think it's a much better idea, thanks! |
In some pages like GapsPage and TimelinePage, I think it will be a better user experience to add a reset button. When the user would like to change the selected bus number he/she will click this button and the inputs will be removed/change to the default input. What do you think about this? @ShayAdler @NoamGaash
The text was updated successfully, but these errors were encountered: