-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method for track Error #51
Open
markst
wants to merge
7
commits into
hanabi1224:master
Choose a base branch
from
markst:issue/26
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a29cef7
Upgrade native SDKs to 4.4.1
markst be83c5e
Progress of `trackError` method channel #26
markst 33806ef
Update changelog.
markst 2ee84aa
Track error passes `Exception` without param name.
markst eeddb21
Track error supports passing `StackTrace` as attachment.
markst 542c2d3
Running example app in error zone
markst 65a0d29
Missing import.
markst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,8 +14,8 @@ A new flutter plugin project. | |
s.author = { 'Your Company' => '[email protected]' } | ||
s.source = { :path => '.' } | ||
s.source_files = 'Classes/**/*' | ||
s.dependency 'AppCenter', '~> 3.3.4' | ||
s.dependency 'AppCenter/Distribute', '~> 3.3.4' | ||
s.dependency 'AppCenter', '~> 4.4.1' | ||
s.dependency 'AppCenter/Distribute', '~> 4.4.1' | ||
s.dependency 'Flutter' | ||
s.platform = :ios, '8.0' | ||
s.static_framework = true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,6 +57,16 @@ class AppCenter { | |
}); | ||
} | ||
|
||
/// Track error | ||
static Future trackErrorAsync(String message, | ||
[Map<String, String>? properties]) async { | ||
await _methodChannel.invokeMethod('trackError', <String, dynamic>{ | ||
'message': message, | ||
'properties': properties, | ||
// Support `ErrorAttachmentLog`? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we think support There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wonder if it might be relevant to support passing stack trace from Dart? runZonedGuarded<Future<void>>(() async {
runApp(App());
}, (error, stackTrace) => AppCenter.trackErrorAsync(error, stackTrace)); |
||
}); | ||
} | ||
|
||
/// Check whether analytics is enalbed | ||
static Future<bool?> isAnalyticsEnabledAsync() async { | ||
return await _methodChannel.invokeMethod('isAnalyticsEnabled'); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if Flutter stack could be passed somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.