Add method for track Error #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markst
commented
Feb 22, 2022
...c/main/kotlin/com/github/hanabi1224/flutter_appcenter_bundle/FlutterAppcenterBundlePlugin.kt
Outdated
Show resolved
Hide resolved
markst
commented
Feb 22, 2022
| await _methodChannel.invokeMethod('trackError', <String, dynamic>{ | ||
| 'message': message, | ||
| 'properties': properties, | ||
| // Support `ErrorAttachmentLog`? |
There was a problem hiding this comment.
do we think support ErrorAttachmentLog is necessary?
There was a problem hiding this comment.
Wonder if it might be relevant to support passing stack trace from Dart?
runZonedGuarded<Future<void>>(() async {
runApp(App());
}, (error, stackTrace) => AppCenter.trackErrorAsync(error, stackTrace));
markst
commented
Apr 27, 2022
| "trackError" -> { | ||
| val message = call.argument<String>("message") | ||
| val properties = call.argument<Map<String, String>>("properties") | ||
| Crashes.trackError(Exception(message), properties, null) |
There was a problem hiding this comment.
wonder if Flutter stack could be passed somehow?
throwable.setStackTrace(new StackTraceElement[]{There was a problem hiding this comment.
final Trace trace = Trace.parseVM(stack.toString()).terse;
final List<Map<String, String>> elements = <Map<String, String>>[];
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs work.
Opening for discussion.
#26