Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert es i18n file #5181

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 12, 2024

What type of PR is this?

/area console
/kind bug
/milestone 2.12.x

What this PR does / why we need it:

取消对 es.yaml 的注释,这应该是在 #4957 中临时注释之后,合并前没有取消注释。

Does this PR introduce a user-facing change?

None

Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/console Issues or PRs related to the Halo Console labels Jan 12, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 12, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 12, 2024
Copy link

f2c-ci-robot bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
@LIlGG
Copy link
Member

LIlGG commented Jan 13, 2024

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 7360a2e into halo-dev:main Jan 13, 2024
7 checks passed
@ruibaby ruibaby deleted the fix/es-i18n-file branch January 13, 2024 06:32
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants