ci: push image to GHCR for pull_request event #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
the
release-note-none
Codecov Report
@@ Coverage Diff @@
## main #4588 +/- ##
============================================
+ Coverage 61.04% 61.14% +0.09%
- Complexity 2566 2580 +14
============================================
Files 374 374
Lines 13168 13221 +53
Branches 938 944 +6
============================================
+ Hits 8039 8084 +45
- Misses 4676 4684 +8
Partials 453 453 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Reverts #4588 According to https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow, we cannot obtain secrets in pull requests, so that we are not able to push docker image for every pull request. ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
对于 Pull Request 触发的 Action 构建得到的镜像也 Push 到 GHCR 仓库中，并使用 pr-{PR编号} 格式的标签。
依赖 halo-sigs/actions#18
Which issue(s) this PR fixes:
Close #4315
Special notes for your reviewer:
Does this PR introduce a user-facing change?