Skip to content

Commit

Permalink
Revert "ci: push image to GHCR for pull_request event" (#4865)
Browse files Browse the repository at this point in the history
Reverts #4588

According to https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow, we cannot obtain secrets in pull requests, so that we are not able to push docker image for every pull request.

```release-note
None
```
  • Loading branch information
JohnNiang authored Nov 16, 2023
1 parent c5dd569 commit a0ea211
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/halo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,5 @@ jobs:
ghcr-token: ${{ secrets.GHCR_TOKEN }}
dockerhub-user: ${{ secrets.DOCKER_USERNAME }}
dockerhub-token: ${{ secrets.DOCKER_TOKEN }}
push: ${{ github.event_name == 'pull_request' || github.event_name == 'push' || github.event_name == 'release' }}
push: ${{ github.event_name == 'push' || github.event_name == 'release' }} # we only push to GHCR if the push is to the next branch
console-ref: ${{ github.event_name == 'release' && github.ref || 'main' }}

0 comments on commit a0ea211

Please sign in to comment.