Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] unify backend rpc #14693

Open
wants to merge 6 commits into
base: ehigham/ctx-persisted-ir
Choose a base branch
from

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Sep 18, 2024

No description provided.


def _parse_matrix_ir(self, code):
return self._jbackend.parse_matrix_ir(code)

def _parse_blockmatrix_ir(self, code):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still used to compute blockmatrix sparsity. All others were just used in tests to test that irs parse (which is done by the _type methods)
I wonder if we can move sparsity into the block matrix type and then this too can be removed?

mtContigs,
par,
)
ctx.References += rg.name -> rg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously this command didn't add the reference to the backend state (See BackendServer and ServiceBackendAPI). It seemed to me that it should. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant