-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] unify backend rpc #14693
base: ehigham/ctx-persisted-ir
Are you sure you want to change the base?
[query] unify backend rpc #14693
Conversation
6a03bb4
to
99e06b5
Compare
99e06b5
to
9283b9c
Compare
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
40cfdd1
to
8ac34e8
Compare
9283b9c
to
7d91073
Compare
|
||
def _parse_matrix_ir(self, code): | ||
return self._jbackend.parse_matrix_ir(code) | ||
|
||
def _parse_blockmatrix_ir(self, code): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still used to compute blockmatrix sparsity. All others were just used in tests to test that irs parse (which is done by the _type
methods)
I wonder if we can move sparsity into the block matrix type and then this too can be removed?
mtContigs, | ||
par, | ||
) | ||
ctx.References += rg.name -> rg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously this command didn't add the reference to the backend state (See BackendServer and ServiceBackendAPI). It seemed to me that it should. Thoughts?
8ac34e8
to
956e751
Compare
f2c39a6
to
2f3f122
Compare
956e751
to
c07ff10
Compare
2f3f122
to
b02c83b
Compare
c07ff10
to
e7782e2
Compare
b02c83b
to
20e6520
Compare
e7782e2
to
7969e05
Compare
20e6520
to
e66b858
Compare
7969e05
to
1142a0d
Compare
e66b858
to
49bdf73
Compare
1142a0d
to
cf4fa39
Compare
49bdf73
to
0ce4a09
Compare
61e7c13
to
d73e22a
Compare
e5f3ddf
to
40f0cc7
Compare
d73e22a
to
9d58bd2
Compare
40f0cc7
to
a51a147
Compare
9d58bd2
to
8fca431
Compare
a51a147
to
cf4e284
Compare
8fca431
to
e633b7f
Compare
cf4e284
to
0e3322a
Compare
e633b7f
to
f57e295
Compare
0e3322a
to
d5ed644
Compare
f57e295
to
0e63a0c
Compare
d5ed644
to
053a62b
Compare
0e63a0c
to
bc035dc
Compare
053a62b
to
c9a1cc5
Compare
bc035dc
to
5a61217
Compare
c9a1cc5
to
51f8702
Compare
5a61217
to
8b2b5cc
Compare
51f8702
to
cbe8467
Compare
8b2b5cc
to
9438e05
Compare
cbe8467
to
cc56f09
Compare
9438e05
to
90dda0d
Compare
cc56f09
to
6bd3033
Compare
No description provided.