Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Remove BlockMatrix persist from Backend interface #14690

Open
wants to merge 2 commits into
base: ehigham/ctx-references
Choose a base branch
from

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Sep 17, 2024

This change is split out from a larger refactoring effort on the various Backend
implementations. The goals of this effort are to provide query-level
configuration to the backend that's currently tied to the lifetime of a backend,
reduce code duplication and reduce state duplication.

In this change, I'm removing blockmatrix persist/unpersist from the Backend
interface by adding BlockMatrixCache: mutable.Map[String, BlockMatrix] to
ExecuteContext. The various reader/writer implementations simply fetch the
block matrix from this cache. For the spark backend, this is backed by a cache
whose lifetime is tied to the spark backend. Since block matrices are not
supported in the local and service backends, the cache is an empty map.

Note that block matrix persist is broken in python (#14689)

@ehigham ehigham marked this pull request as ready for review September 17, 2024 21:46
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch 2 times, most recently from 15f2275 to 71fcb35 Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/ctx-bm-cache branch 2 times, most recently from 5c17594 to 75bf1da Compare October 30, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant