-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Remove BlockMatrix persist from Backend interface #14690
Open
ehigham
wants to merge
2
commits into
ehigham/ctx-references
Choose a base branch
from
ehigham/ctx-bm-cache
base: ehigham/ctx-references
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+108
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2024
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 17, 2024
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
September 19, 2024 20:52
92da6f0
to
4576acf
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
September 19, 2024 20:52
b0be25e
to
6038f9b
Compare
This was referenced Sep 20, 2024
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 1, 2024 19:44
4576acf
to
8a42e93
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
2 times, most recently
from
October 1, 2024 20:03
15f2275
to
71fcb35
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 8, 2024 19:18
341e6a7
to
1682964
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 8, 2024 19:18
71fcb35
to
360af7c
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 8, 2024 20:30
1682964
to
b1c0d04
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 8, 2024 20:30
360af7c
to
d16f9c6
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 16, 2024 20:02
b1c0d04
to
84ddcf3
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 16, 2024 20:02
d16f9c6
to
783df28
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 16, 2024 21:30
84ddcf3
to
a2ff477
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 16, 2024 21:30
783df28
to
7e661e4
Compare
1 task
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 17, 2024 14:59
a2ff477
to
df5c723
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 17, 2024 15:00
7e661e4
to
952b01d
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 21, 2024 15:24
df5c723
to
adc0602
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 21, 2024 15:24
952b01d
to
a265389
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 21, 2024 18:50
adc0602
to
24b20f3
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 23, 2024 22:13
953a6fd
to
323eaf6
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 23, 2024 23:49
4cc6ede
to
ea44ad8
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 23, 2024 23:49
323eaf6
to
a770836
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 24, 2024 01:28
ea44ad8
to
a5e3c37
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 24, 2024 01:28
a770836
to
fb44ff4
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 24, 2024 01:58
a5e3c37
to
a435a0a
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 24, 2024 01:58
fb44ff4
to
5f5dd21
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 24, 2024 04:31
a435a0a
to
80bbbc2
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 24, 2024 04:31
5f5dd21
to
8794b52
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 24, 2024 04:48
80bbbc2
to
f9f45d6
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 24, 2024 04:48
8794b52
to
19154ce
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 25, 2024 15:28
f9f45d6
to
64a1410
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 25, 2024 15:28
19154ce
to
67ba335
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 29, 2024 17:46
64a1410
to
756ba40
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 29, 2024 17:46
67ba335
to
40672f3
Compare
1 task
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 29, 2024 21:47
756ba40
to
539e25f
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
2 times, most recently
from
October 30, 2024 22:27
5c17594
to
75bf1da
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 31, 2024 15:47
539e25f
to
2b266d0
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 31, 2024 15:47
75bf1da
to
5ae52ce
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
November 4, 2024 22:15
2b266d0
to
b069621
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
November 4, 2024 22:15
5ae52ce
to
8c4d66e
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
November 19, 2024 17:08
b069621
to
d229670
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
November 19, 2024 17:08
8c4d66e
to
8e38c0a
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
November 20, 2024 17:00
d229670
to
07a390d
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
November 20, 2024 17:00
8e38c0a
to
bcd42eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is split out from a larger refactoring effort on the various Backend
implementations. The goals of this effort are to provide query-level
configuration to the backend that's currently tied to the lifetime of a backend,
reduce code duplication and reduce state duplication.
In this change, I'm removing blockmatrix persist/unpersist from the
Backend
interface by adding
BlockMatrixCache: mutable.Map[String, BlockMatrix]
toExecuteContext
. The various reader/writer implementations simply fetch theblock matrix from this cache. For the spark backend, this is backed by a cache
whose lifetime is tied to the spark backend. Since block matrices are not
supported in the local and service backends, the cache is an empty map.
Note that block matrix persist is broken in python (#14689)