Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The BOOM-bardier barrrel #843

Merged
merged 5 commits into from
Dec 1, 2024
Merged

The BOOM-bardier barrrel #843

merged 5 commits into from
Dec 1, 2024

Conversation

Fueredoriku
Copy link
Contributor

@Fueredoriku Fueredoriku commented Oct 2, 2024

TODO:

Done:

  • Fixed Fix scaling of sticky projectiles and the like #164
  • Fixed Objectpool for stickyprojectiles #602
  • Fixed issue where objectpools and their holders persisted in scene hierarchy
  • Fixed issue where players would not get ignited by fire mesh projectiles
  • Fixed issue where decals would sometime get attached to AiTargetPosition prefab
  • Added disabling of crosshair when in spectating mode
  • Added object pooling for trail fire
  • Adjusted fire particle scaling on fire extension model
  • Adjusted stickyprojectiles to spawn at oldposition instead for better visuals

Note:
Dynamites can't be detonated in training grounds until the zooming fix in #879 is merged, but it should work fine in all other situations.

@Fueredoriku Fueredoriku self-assigned this Oct 2, 2024
@Fueredoriku Fueredoriku linked an issue Oct 2, 2024 that may be closed by this pull request
@Fueredoriku Fueredoriku force-pushed the feature/barrel/dynamite branch from f4c929c to 45cc2f3 Compare November 26, 2024 02:24
- Fixed issue where objectpools and their holders persited in scene hierarchy
- Fixed issue where players would not get ignited by fire mesh projectiles
- Added object pooling for trail fire
- Adjusted fire particle scaling on fire extension model
- Adjusted stickyprojectiles to spawn at oldposition instead for better visuals
@Fueredoriku Fueredoriku force-pushed the feature/barrel/dynamite branch from 45cc2f3 to 1255c7d Compare November 26, 2024 02:25
@Fueredoriku Fueredoriku linked an issue Nov 30, 2024 that may be closed by this pull request
2 tasks
@Fueredoriku Fueredoriku marked this pull request as ready for review November 30, 2024 23:06
@Fueredoriku Fueredoriku requested a review from toberge November 30, 2024 23:06
@Fueredoriku Fueredoriku force-pushed the feature/barrel/dynamite branch 5 times, most recently from c430637 to 9f7d8b0 Compare December 1, 2024 00:11
@Fueredoriku Fueredoriku force-pushed the feature/barrel/dynamite branch from 9f7d8b0 to f39fb14 Compare December 1, 2024 13:08
- Add early detonation with fire extension
- Add explosive barrel variant with enlarger extension
- Add trashuplink detonation targeting
- Remove crosshairs when spectating
- Fix issue where decals could be placed on AiTargetPosition prefab
- Add explosion screen shakes for closing #739
- Add new secret names and loading screen tips
@Fueredoriku Fueredoriku force-pushed the feature/barrel/dynamite branch from f39fb14 to 00a472a Compare December 1, 2024 13:11
@Fueredoriku Fueredoriku requested a review from toberge December 1, 2024 13:15
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is prolly fine

@Fueredoriku Fueredoriku merged commit 67cb671 into dev Dec 1, 2024
@Fueredoriku Fueredoriku deleted the feature/barrel/dynamite branch December 1, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
2 participants