Point to the latest JDT and asm #9884

vegegoku · 2023-12-31T11:25:44Z

Update build scripts to point to the latest JDT [3.36.0.v20231115-1055] and the latest asm 9.6

fix #9871
related to #9869

.gitignore

niloc132 · 2023-12-31T19:53:04Z

Do you think it would make sense to also update SourceLevel to accept 17 as a value, and pass that to JDT? That should at least get us text blocks and sealed classes "for free" (though of course we still need tests).

I think that makes sense to include in this PR, and give that a quick test so that we know that the new jdt actually does something.

jnehlmeier · 2024-01-02T11:37:49Z

This version should also already support Java 21 (except some preview features).

eclipse-jdt/eclipse.jdt.core#890

Most interesting would be record patterns and pattern matching for switch.

niloc132 · 2024-01-02T15:30:19Z

@jnehlmeier unfortunately Ahmad has found that builds of JDT past 4.27 require a minimum of Java 17 to compile and run, so if we're dropping just Java 8 for now, we can't update to 4.29. Additionally, there is something funny happening with a new required dependency of the jdt core, and shading it into the gwt-dev.jar seems to prevent classes from being loaded in that jar correctly.

If you want to push for going all the way to Java 21 now, you could take that up, discuss dropping both Java 8 and 11 on the mailing list, and work up a fix for the new batch dependency? Otherwise I continue to be in favor of a more incremental approach (especially as record/pattern matching is likely going to require more custom codegen to make sense in js).

dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java

dev/core/test/com/google/gwt/dev/jjs/impl/Java17AstTest.java

.github/workflows/full-check.yml

dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java

dev/core/test/com/google/gwt/dev/jjs/impl/Java17AstTest.java

niloc132

I didn't think this through - but I think you're going to need to re-introduce the isJava8 flag as isJava11 so that the Java 17 test won't try to be compiled with Java 11. LMK if you want a hand, this Ant wiring is a pain.

user/test/com/google/gwt/dev/jjs/Java17Test.java

user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java17Test.java

niloc132 · 2024-01-18T21:10:25Z

Cherry-pick that last commit to its own PR? Looks like it will need to have at least one line wrapped too, to fix stylecheck.

dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java

user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java17Test.java

user/test/com/google/gwt/dev/jjs/Java17Test.java

niloc132

Looks good, just some last minute cleanup. After #9905 is merged let's do one more CI run (to be sure github actions is happy to run on 11/17/21), then merge?

niloc132 · 2024-01-31T02:36:06Z

.github/workflows/full-check.yml

@@ -29,7 +30,8 @@ jobs:
      - name: Checkout GWT tools into a sibling directory
        uses: actions/checkout@v4
        with:
-          repository: 'gwtproject/tools'
+          repository: 'vegegoku/tools'
+          ref: 'java-17-support'


With the tools patch merged, revert this (in both yml files)

niloc132 · 2024-01-31T02:36:31Z

.github/workflows/full-check.yml

@@ -1,4 +1,4 @@
-# Run all tests and builds all aspects of GWT using Java 11 and 17. Runs
+# Run all tests and builds all aspects of GWT using Java 8, 11, and 17. Runs


Suggested change

# Run all tests and builds all aspects of GWT using Java 8, 11, and 17. Runs

# Run all tests and builds all aspects of GWT using Java 11, 17, and 21. Runs

niloc132 · 2024-01-31T02:36:48Z

dev/build.xml

@@ -2,7 +2,7 @@
  <property name="gwt.root" location=".."/>
  <property name="project.tail" value="dev"/>
  <property name="test.args" value="-ea"/>
-  <property name="test.jvmargs" value="-ea"/>
+  <property name="test.jvmargs" value="-ea -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=8005"/>


Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6 fix gwtproject#9871 related to gwtproject#9869

Point CI to the forked tools repository that has java 17 support changes. fix gwtproject#9871 related to gwtproject#9869

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added. fix gwtproject#9871 related to gwtproject#9869

niloc132 reviewed Dec 31, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

niloc132 added this to the 2.12 milestone Dec 31, 2023

niloc132 added the java17 label Dec 31, 2023

vegegoku force-pushed the java-17-support branch from 3e12be6 to 25e9b91 Compare December 31, 2023 13:00

vegegoku force-pushed the java-17-support branch 2 times, most recently from f5e28a1 to 9b37765 Compare January 2, 2024 10:48

niloc132 reviewed Jan 2, 2024

View reviewed changes

dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java Outdated Show resolved Hide resolved

vegegoku force-pushed the java-17-support branch 2 times, most recently from 4db8576 to f904c46 Compare January 3, 2024 22:16

niloc132 reviewed Jan 3, 2024

View reviewed changes

dev/core/test/com/google/gwt/dev/jjs/impl/Java17AstTest.java Outdated Show resolved Hide resolved

vegegoku force-pushed the java-17-support branch from f904c46 to 608dc02 Compare January 4, 2024 12:26

vegegoku force-pushed the java-17-support branch from d430a04 to 46dd5c7 Compare January 15, 2024 12:47

niloc132 reviewed Jan 15, 2024

View reviewed changes

vegegoku force-pushed the java-17-support branch 2 times, most recently from faa9aaf to 1cf0047 Compare January 17, 2024 13:31

niloc132 reviewed Jan 17, 2024

View reviewed changes

user/test/com/google/gwt/dev/jjs/Java17Test.java Outdated Show resolved Hide resolved

user/test/com/google/gwt/dev/jjs/Java17Test.java Outdated Show resolved Hide resolved

user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java17Test.java Show resolved Hide resolved

vegegoku force-pushed the java-17-support branch from 1cf0047 to 012efff Compare January 17, 2024 13:48

vegegoku force-pushed the java-17-support branch 2 times, most recently from 5b61a45 to 3aa51cb Compare January 21, 2024 09:59

niloc132 reviewed Jan 24, 2024

View reviewed changes

dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java Outdated Show resolved Hide resolved

dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java Outdated Show resolved Hide resolved

niloc132 reviewed Jan 24, 2024

View reviewed changes

user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java17Test.java Show resolved Hide resolved

niloc132 reviewed Jan 24, 2024

View reviewed changes

user/test/com/google/gwt/dev/jjs/Java17Test.java Outdated Show resolved Hide resolved

vegegoku force-pushed the java-17-support branch 2 times, most recently from bb97ac6 to b6ce395 Compare January 25, 2024 22:29

vegegoku requested a review from niloc132 January 25, 2024 22:29

vegegoku force-pushed the java-17-support branch from b6ce395 to eae2c83 Compare January 28, 2024 17:25

niloc132 reviewed Jan 31, 2024

View reviewed changes

niloc132 and others added 11 commits January 31, 2024 14:44

Update CI to use 11+, use 21 for artifacts

e765efa

Update errorprone, remove isJava8 checks

4534d7c

Distribute errorprone suppression, add -noverify

40ec508

Temporary commit to test nightlies

5069922

Disable java21 builds until asm is updated

c7ed702

Roll back noverify, we don't need it with the current build setup

9f3e536

Simplest workaround for https://bugs.openjdk.org/browse/JDK-8323657

04dffe1

Also pass noverify to ci's test.jvmargs

6feb5d9

Point to the latest JDT and asm

4e69145

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6 fix gwtproject#9871 related to gwtproject#9869

Fix fork CI tools reference

3323f66

Point CI to the forked tools repository that has java 17 support changes. fix gwtproject#9871 related to gwtproject#9869

Add js compile tests

9c9b874

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added. fix gwtproject#9871 related to gwtproject#9869

vegegoku force-pushed the java-17-support branch from eae2c83 to 9c9b874 Compare January 31, 2024 11:46

vegegoku closed this Jan 31, 2024

vegegoku deleted the java-17-support branch January 31, 2024 12:22

vegegoku mentioned this pull request Jan 31, 2024

Update JDT and asm for Java 17 language support #9911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Point to the latest JDT and asm #9884

Point to the latest JDT and asm #9884

vegegoku commented Dec 31, 2023 •

edited

Loading

niloc132 commented Dec 31, 2023

jnehlmeier commented Jan 2, 2024

niloc132 commented Jan 2, 2024

niloc132 left a comment

niloc132 commented Jan 18, 2024

niloc132 left a comment

niloc132 Jan 31, 2024

niloc132 Jan 31, 2024

niloc132 Jan 31, 2024

		@@ -1,4 +1,4 @@
		# Run all tests and builds all aspects of GWT using Java 11 and 17. Runs
		# Run all tests and builds all aspects of GWT using Java 8, 11, and 17. Runs

Point to the latest JDT and asm #9884

Point to the latest JDT and asm #9884

Conversation

vegegoku commented Dec 31, 2023 • edited Loading

niloc132 commented Dec 31, 2023

jnehlmeier commented Jan 2, 2024

niloc132 commented Jan 2, 2024

niloc132 left a comment

Choose a reason for hiding this comment

niloc132 commented Jan 18, 2024

niloc132 left a comment

Choose a reason for hiding this comment

niloc132 Jan 31, 2024

Choose a reason for hiding this comment

niloc132 Jan 31, 2024

Choose a reason for hiding this comment

niloc132 Jan 31, 2024

Choose a reason for hiding this comment

vegegoku commented Dec 31, 2023 •

edited

Loading