Skip to content

Commit

Permalink
Fix fork CI tools reference
Browse files Browse the repository at this point in the history
Point CI to the forked tools repository that has java 17 support changes.

fix #9871
related to #9869
  • Loading branch information
vegegoku committed Jan 15, 2024
1 parent 3808563 commit 46dd5c7
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/full-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ jobs:
- name: Checkout GWT tools into a sibling directory
uses: actions/checkout@v4
with:
repository: 'Vertispan/tools'
ref: 'errorprone-2.23'
repository: 'vegegoku/tools'
ref: 'java-17-support'
path: 'tools'
- name: Set up JDK ${{ matrix.java-version }}
# GWT requires Java 11+ to build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/quick-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ jobs:
- name: Checkout GWT tools into a sibling directory
uses: actions/checkout@v4
with:
repository: 'Vertispan/tools'
ref: 'errorprone-2.23'
repository: 'vegegoku/tools'
ref: 'java-17-support'
path: 'tools'
- name: Set up JDK ${{ matrix.java-version }}
# GWT presently requires Java 11+ to build
Expand Down
3 changes: 1 addition & 2 deletions dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ public void endVisit(BreakStatement x, BlockScope scope) {

@Override
public void endVisit(CaseStatement x, BlockScope scope) {
if(x.isExpr){
if (x.isExpr) {
InternalCompilerException excption =
new InternalCompilerException("Switch expressions not yet supported");
excption.addNode(new JCaseStatement(makeSourceInfo(x), null));
Expand Down Expand Up @@ -3718,7 +3718,6 @@ private JType[] processCastType(TypeBinding type) {
}
}


private boolean isFunctionalInterfaceWithMethod(ReferenceBinding referenceBinding, Scope scope,
String samSignature) {
if (!referenceBinding.isInterface()) {
Expand Down
7 changes: 3 additions & 4 deletions dev/core/test/com/google/gwt/dev/jjs/impl/Java17AstTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void testSealedClassesNotPermitted() {
"}");
compileSnippet("void", "Shape rectangle = new Rectangle();");
fail("Compile should have failed but succeeded.");
}catch (Exception e) {
} catch (Exception e) {
if (!(e.getCause() instanceof UnableToCompleteException)
&& !(e instanceof UnableToCompleteException)) {
e.printStackTrace();
Expand All @@ -100,7 +100,7 @@ public void testSealedClassesNotPermitted() {
}
}

public void testSwitchExpressionsNotSupported(){
public void testSwitchExpressionsNotSupported() {
try {
compileSnippet("void", "var month = Months.JUNE;" +
"var result = switch(month) {\n" +
Expand All @@ -110,15 +110,14 @@ public void testSwitchExpressionsNotSupported(){
" default -> 0;" +
"};");
fail("Compile should have failed but succeeded, switch expression is not supported.");
}catch (Exception e){
} catch (Exception e) {
if (!(e.getCause() instanceof InternalCompilerException)
&& !(e instanceof InternalCompilerException)) {
e.printStackTrace();
fail();
}
assertEquals("Switch expressions not yet supported", e.getMessage());
}

}

@Override
Expand Down

0 comments on commit 46dd5c7

Please sign in to comment.