Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Add name to batch config #8983

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

tyler-hoffman
Copy link
Contributor

Adds name to BatchConfig. This will allow for individual named files in a new gx/batch_config/ directory, and allow for bindings to have the yaml shape

name: my_binding
batch_config: <fk_to_batch_config>
expectation_suite: <fk_to_expectation_suite>
  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 9a083e8
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65674962c658e70008ce9091

@ghost
Copy link

ghost commented Nov 20, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tyler-hoffman tyler-hoffman changed the title Add name to batch config [MAINTENANCE] Add name to batch config Nov 29, 2023
@tyler-hoffman tyler-hoffman added this pull request to the merge queue Nov 29, 2023
Merged via the queue into develop with commit 8240c79 Nov 29, 2023
59 checks passed
@tyler-hoffman tyler-hoffman deleted the f/named-batch-config branch November 29, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants