Skip to content

Commit

Permalink
[MAINTENANCE] Add name to batch config (#8983)
Browse files Browse the repository at this point in the history
  • Loading branch information
tyler-hoffman authored Nov 29, 2023
1 parent 8623028 commit 8240c79
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions great_expectations/core/batch_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class Config:
arbitrary_types_allowed = True

context: AbstractDataContext
name: str
datasource_name: str
data_asset_name: str

Expand Down
2 changes: 2 additions & 0 deletions tests/core/test_batch_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def test_data_asset(
mock_asset: DataAsset,
):
batch_config = BatchConfig(
name="test_batch_config",
context=data_context,
datasource_name=fds_data_context_datasource_name,
data_asset_name=mock_asset_name,
Expand All @@ -71,6 +72,7 @@ def test_build_batch_request(
mock_asset_name: str,
):
batch_config = BatchConfig(
name="test_batch_config",
context=data_context,
datasource_name=fds_data_context_datasource_name,
data_asset_name=mock_asset_name,
Expand Down
2 changes: 2 additions & 0 deletions tests/validator/test_v1_validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def batch_config(
) -> BatchConfig:
return BatchConfig(
context=fds_data_context,
name="test_batch_config",
datasource_name=fds_data_context_datasource_name,
data_asset_name="trip_asset",
)
Expand All @@ -61,6 +62,7 @@ def batch_config_with_event_type_splitter(
) -> BatchConfig:
return BatchConfig(
context=fds_data_context,
name="test_batch_config",
datasource_name=fds_data_context_datasource_name,
data_asset_name="trip_asset_split_by_event_type",
)
Expand Down

0 comments on commit 8240c79

Please sign in to comment.