Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Deprecate DataContext.add_or_update_datasource #10784

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Dec 16, 2024

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 421110e
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6762db029e935d00083f21c3

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (23b1520) to head (421110e).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...data_context/data_context/abstract_data_context.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10784      +/-   ##
===========================================
- Coverage    80.67%   80.67%   -0.01%     
===========================================
  Files          464      464              
  Lines        40348    40350       +2     
===========================================
+ Hits         32552    32553       +1     
- Misses        7796     7797       +1     
Flag Coverage Δ
3.10 69.96% <50.00%> (-0.01%) ⬇️
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 clickhouse ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark_connect ?
3.11 69.96% <50.00%> (-0.01%) ⬇️
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.11 trino ?
3.12 69.96% <50.00%> (-0.01%) ⬇️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.38% <50.00%> (-0.01%) ⬇️
3.12 aws_deps 46.18% <50.00%> (+<0.01%) ⬆️
3.12 big 54.72% <50.00%> (-0.01%) ⬇️
3.12 bigquery 48.47% <50.00%> (+<0.01%) ⬆️
3.12 databricks 50.33% <50.00%> (+<0.01%) ⬆️
3.12 filesystem 62.65% <50.00%> (-0.01%) ⬇️
3.12 mssql 51.24% <50.00%> (-0.01%) ⬇️
3.12 mysql 51.66% <50.00%> (-0.01%) ⬇️
3.12 postgresql 54.38% <50.00%> (-0.01%) ⬇️
3.12 snowflake 51.06% <50.00%> (-0.01%) ⬇️
3.12 spark 57.66% <50.00%> (-0.01%) ⬇️
3.12 spark_connect 46.47% <50.00%> (+<0.01%) ⬆️
3.12 trino 52.21% <50.00%> (-0.01%) ⬇️
3.9 69.98% <50.00%> (-0.01%) ⬇️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.37% <50.00%> (-0.01%) ⬇️
3.9 aws_deps 46.20% <50.00%> (+<0.01%) ⬆️
3.9 big 54.73% <50.00%> (-0.01%) ⬇️
3.9 bigquery 48.47% <50.00%> (+<0.01%) ⬆️
3.9 clickhouse 43.08% <50.00%> (+<0.01%) ⬆️
3.9 databricks 50.33% <50.00%> (-0.01%) ⬇️
3.9 filesystem 62.66% <50.00%> (-0.01%) ⬇️
3.9 mssql 51.23% <50.00%> (-0.01%) ⬇️
3.9 mysql 51.64% <50.00%> (-0.01%) ⬇️
3.9 postgresql 54.37% <50.00%> (-0.01%) ⬇️
3.9 snowflake 51.06% <50.00%> (-0.01%) ⬇️
3.9 spark 57.62% <50.00%> (-0.01%) ⬇️
3.9 spark_connect 46.48% <50.00%> (+<0.01%) ⬆️
3.9 trino 52.20% <50.00%> (-0.01%) ⬇️
cloud 0.00% <0.00%> (ø)
docs-basic 54.09% <50.00%> (-0.01%) ⬇️
docs-creds-needed 52.98% <50.00%> (-0.01%) ⬇️
docs-spark 52.46% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdkini cdkini enabled auto-merge December 17, 2024 18:42
@cdkini cdkini added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@cdkini cdkini added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@cdkini cdkini enabled auto-merge December 18, 2024 14:24
@cdkini cdkini added this pull request to the merge queue Dec 18, 2024
Merged via the queue into develop with commit 53d48d0 Dec 18, 2024
71 checks passed
@cdkini cdkini deleted the m/core-604/add_or_update_ds branch December 18, 2024 15:40
Shinnnyshinshin added a commit that referenced this pull request Dec 18, 2024
…ps://github.com/great-expectations/great_expectations into m/zelda-1183/zelda-1188/adding-databricks-types

* 'm/zelda-1183/zelda-1188/adding-databricks-types' of https://github.com/great-expectations/great_expectations:
  [MAINTENANCE] Allow `CheckpointResult` and `ActionContext` to be importable from top-level checkpoint module (#10788)
  [DOCS] Custom Actions (#10772)
  [DOCS] Remove unnecessary escape character in Expectation for Gallery (#10780)
  [MAINTENANCE] Deprecate `DataContext.add_or_update_datasource` (#10784)
Shinnnyshinshin added a commit that referenced this pull request Dec 18, 2024
…thub.com/great-expectations/great_expectations into m/zelda-1183/zelda-1188/databricks-tests

* 'm/zelda-1183/zelda-1188/databricks-tests' of https://github.com/great-expectations/great_expectations:
  [MAINTENANCE] Allow `CheckpointResult` and `ActionContext` to be importable from top-level checkpoint module (#10788)
  [DOCS] Custom Actions (#10772)
  [DOCS] Remove unnecessary escape character in Expectation for Gallery (#10780)
  [MAINTENANCE] Deprecate `DataContext.add_or_update_datasource` (#10784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants