Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Simplify logic around data context ID creation #10404

Closed
wants to merge 5 commits into from

Merge branch 'develop' into m/_/simplify_data_context_id_logic

b3c9c56
Select commit
Loading
Failed to load commit list.
Closed

[MAINTENANCE] Simplify logic around data context ID creation #10404

Merge branch 'develop' into m/_/simplify_data_context_id_logic
b3c9c56
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 20, 2024 in 3s

66.76% (-13.21%) compared to 1e13ef6

View this Pull Request on Codecov

66.76% (-13.21%) compared to 1e13ef6

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.76%. Comparing base (1e13ef6) to head (b3c9c56).

✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (1e13ef6) and HEAD (b3c9c56). Click for more details.

HEAD has 73 uploads less than BASE
Flag BASE (1e13ef6) HEAD (b3c9c56)
3.10 2 1
3.11 2 1
3.9 2 1
3.8 2 1
3.12 2 1
3.8 big 2 0
3.8 aws_deps 2 0
3.12 big 2 0
3.12 aws_deps 2 0
3.8 filesystem 2 0
3.8 spark_connect 2 0
3.12 filesystem 2 0
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 2 0
3.12 spark_connect 2 0
docs-spark 1 0
3.8 mysql 2 0
docs-basic 1 0
docs-creds-needed 1 0
3.12 mysql 2 0
3.8 mssql 2 0
cloud 1 0
3.8 postgresql 2 0
3.12 mssql 2 0
3.8 trino 2 0
3.12 postgresql 2 0
3.12 trino 1 0
3.8 spark 1 0
3.12 spark 1 0
3.8 databricks 1 0
3.8 snowflake 1 0
3.11 big 1 0
3.9 big 1 0
3.11 aws_deps 1 0
3.9 aws_deps 1 0
3.10 big 1 0
3.10 aws_deps 1 0
3.11 filesystem 1 0
3.9 filesystem 1 0
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.10 filesystem 1 0
3.11 spark_connect 1 0
3.9 spark_connect 1 0
3.10 spark_connect 1 0
3.9 mysql 1 0
3.11 mysql 1 0
3.10 mysql 1 0
3.11 mssql 1 0
3.9 mssql 1 0
3.10 postgresql 1 0
3.9 postgresql 1 0
3.9 trino 1 0
3.11 trino 1 0
3.10 trino 1 0
3.10 mssql 1 0
3.11 postgresql 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10404       +/-   ##
============================================
- Coverage    79.96%   66.76%   -13.21%     
============================================
  Files          459      457        -2     
  Lines        39976    39974        -2     
============================================
- Hits         31966    26687     -5279     
- Misses        8010    13287     +5277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.